Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: unclear that esqiusse_server(data_rv) needs to have a name #227

Open
daattali opened this issue Sep 21, 2022 · 0 comments
Open

Docs: unclear that esqiusse_server(data_rv) needs to have a name #227

daattali opened this issue Sep 21, 2022 · 0 comments

Comments

@daattali
Copy link
Contributor

Documentation says

A reactiveValues with at least a slot data containing a data.frame to use in the module. And a slot name corresponding to the name of the data.frame.

That wording is ambiguous, mostly because the "and" is in a new sentence, it made me think that only data is required and the name is optional. It also made sense to me, because I would have thought that if a name is not provided then you can just default to a sensible name such as "data" or "df" (maybe you can consider this?)

Additionally, "at least" implies that there are more optional slots - are there more supported slots? If yes, they should be described. If not, then the word "at least" should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant