Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: backspace in list when select all list content #2230

Merged
merged 1 commit into from May 16, 2024
Merged

fix: backspace in list when select all list content #2230

merged 1 commit into from May 16, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented May 13, 2024

close #2185

@Jocs Jocs marked this pull request as ready for review May 13, 2024 07:04
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label May 13, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 13, 2024 •
edited

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label May 13, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label May 13, 2024
@codecov Codecov
Copy link

codecov bot commented May 13, 2024 •
edited

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 30.84%. Comparing base (08f41cf) to head (2e6d483).

Files Patch % Lines
...kages/docs/src/commands/commands/delete.command.ts 0.00% 14 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #2230      +/-   ##
==========================================
- Coverage   30.84%   30.84%   -0.01%     
==========================================
  Files        1358     1358              
  Lines       70668    70669       +1     
  Branches    14870    14870              
==========================================
  Hits        21799    21799              
- Misses      48869    48870       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oumomomo oumomomo added the qa:untested This PR is ready to be tested label May 13, 2024
@univer-bot univer-bot bot removed the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label May 13, 2024
@oumomomo oumomomo added qa:verified This PR has already by verified by a QA and is considered good enough to be merge qa:rejected and removed qa:untested This PR is ready to be tested qa:verified This PR has already by verified by a QA and is considered good enough to be merge labels May 13, 2024
@Jocs Jocs force-pushed the fix/delete-list-content branch from 9f4a897 to 2e6d483 Compare May 15, 2024 11:43
@oumomomo oumomomo added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:rejected labels May 15, 2024
@Jocs Jocs merged commit e58a69e into dev May 16, 2024
9 checks passed
@Jocs Jocs deleted the fix/delete-list-content branch May 16, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gggpound Gggpound Gggpound approved these changes

@DR-Univer DR-Univer Awaiting requested review from DR-Univer DR-Univer is a code owner

@lumixraku lumixraku Awaiting requested review from lumixraku lumixraku is a code owner

Assignees
No one assigned
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Milestone
No milestone
3 participants
@Jocs @Gggpound @oumomomo