Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sheets): bugfix for freeze & hover-manager-service & data-validation #2233

Merged
merged 12 commits into from
May 15, 2024
Merged

fix(sheets): bugfix for freeze & hover-manager-service & data-validation #2233

merged 12 commits into from
May 15, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented May 13, 2024 •
edited

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label May 13, 2024
@codecov Codecov
Copy link

codecov bot commented May 13, 2024 •
edited

Codecov Report

Attention: Patch coverage is 0% with 78 lines in your changes are missing coverage. Please review.

Project coverage is 30.84%. Comparing base (7f1540f) to head (4b9ff12).
Report is 9 commits behind head on dev.

Files Patch % Lines
...eets-ui/src/controllers/hover-render.controller.ts 0.00% 18 Missing ⚠️
...ta-validation/src/validators/checkbox-validator.ts 0.00% 11 Missing ⚠️
...ine-render/src/components/sheets/sheet-skeleton.ts 0.00% 10 Missing ⚠️
...validation/src/controllers/dv-render.controller.ts 0.00% 9 Missing ⚠️
...heets-ui/src/controllers/auto-height.controller.ts 0.00% 9 Missing ⚠️
...i/src/controllers/cell-custom-render.controller.ts 0.00% 8 Missing ⚠️
...ets-data-validation/src/widgets/dropdown-widget.ts 0.00% 5 Missing ⚠️
...ets-data-validation/src/widgets/checkbox-widget.ts 0.00% 3 Missing ⚠️
...src/views/formula-input/checkbox-formula-input.tsx 0.00% 2 Missing ⚠️
...es/sheets-data-validation/src/views/list/index.tsx 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #2233      +/-   ##
==========================================
+ Coverage   30.77%   30.84%   +0.06%     
==========================================
  Files        1275     1358      +83     
  Lines       70192    70652     +460     
  Branches    14789    14867      +78     
==========================================
+ Hits        21600    21791     +191     
- Misses      48592    48861     +269

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 13, 2024 •
edited

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@wzhudev
Copy link
Member

wzhudev commented May 14, 2024

The title of this PR need to be more specific.

@oumomomo
Copy link

#2162 还是有问题，已评论在issue内

@univer-bot
Copy link

univer-bot bot commented May 14, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

#2162 There is still a problem, it has been commented in the issue

@oumomomo oumomomo added qa:rejected and removed qa:untested This PR is ready to be tested labels May 14, 2024
@weird94 weird94 changed the title fix(sheets): daily bugfix fix(sheets): bugfix about freeze & hover-manager-service & data-validation May 14, 2024
@oumomomo oumomomo added qa:untested This PR is ready to be tested qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:rejected qa:untested This PR is ready to be tested labels May 14, 2024
@weird94 weird94 changed the title fix(sheets): bugfix about freeze & hover-manager-service & data-validation fix(sheets): bugfix for freeze & hover-manager-service & data-validation May 15, 2024
@weird94 weird94 merged commit 9636037 into dev May 15, 2024
7 of 9 checks passed
@weird94 weird94 deleted the fix/daily-0511 branch May 15, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dushusir Dushusir Dushusir approved these changes

@DR-Univer DR-Univer DR-Univer approved these changes

@jikkai jikkai Awaiting requested review from jikkai jikkai is a code owner

@wzhudev wzhudev Awaiting requested review from wzhudev wzhudev is a code owner

@lumixraku lumixraku Awaiting requested review from lumixraku lumixraku is a code owner

Assignees
No one assigned
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Data validation-check box problem collection
5 participants
@weird94 @wzhudev @oumomomo @Dushusir @DR-Univer