Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Data validation-check box problem collection #2162

Closed
2 tasks done
oumomomo opened this issue May 6, 2024 · 4 comments · Fixed by #2233
Closed
2 tasks done

[Bug] Data validation-check box problem collection #2162

oumomomo opened this issue May 6, 2024 · 4 comments · Fixed by #2233
Assignees

Comments

@oumomomo
Copy link

oumomomo commented May 6, 2024

Before you submit this issue, have you checked the following

  • Is this really a problem?
  • I have searched the Github Issues for similar issues, but did not find anything.

Affected packages and versions

staging

Reproduction link

问题1、设置了未选中值后再删除未选中值保存时会有报错提示
操作步骤:
1、新增数据验证,条件类型选择复选框
2、勾选在单元格内使用自定义值
3、填写选中值,不填写未选中值点击确认
4、再次点击刚刚保存的数据验证
5、删除选中值的内容点击确认

问题2、勾选在单元格内使用自定义值,当选中值=未选中值时,复选框无法取消勾选
操作步骤:
1、数据验证内选择复选框,勾选在单元格内使用自定义值
2、设置选中值=未选中值点击确定
3、点击复选框

Expected behavior

问题1:
预期是不会报错?还是报错? 新建时不输入值也可以正常保存

问题2:
有错误码提示选中值与未选中值分别对应不同的值

Actual behavior

问题1、
新建时不输入值可以正常保存,新建时输入值保存后再次删掉会有错误提示
2024_5_6 16_36_08 video.webm

问题2、
无错误提示,当选中值=未选中值时复选框无法取消勾选
2024_5_6 16_42_19 video.webm

System information

No response

@oumomomo oumomomo added the bug Something isn't working label May 6, 2024
@univer-bot
Copy link

univer-bot bot commented May 6, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Origin Title: [Bug] 数据验证-复选框问题合集

Title: [Bug] Data validation-check box problem collection


Before you submit this issue, have you checked the following

  • Is this really a problem?
  • I have searched the Github Issues for similar issues, but did not find anything.

Affected packages and versions

staging

Reproduction link

Question 1. After setting an unselected value and then deleting the unselected value and saving it, an error message will appear.
Steps:

  1. Added data verification and condition type selection checkbox
  2. Check Use custom values ​​in cells
  3. Fill in the selected value, and click Confirm if you do not fill in the unselected value.
  4. Click again to verify the data you just saved.
  5. Delete the contents of the selected value and click Confirm.

Question 2. Check Use custom value in cell. When selected value = unselected value, the check box cannot be unchecked.
Steps:

  1. Select the checkbox in the data validation and check Use custom values ​​in cells
  2. Set selected value = unselected value and click OK
  3. Click the check box

Expected behavior

Question 1:
Is it expected that no error will be reported? Or reporting an error? You can save it normally without entering a value when creating a new one.

Question 2:
There is an error code prompting that the selected value and the unselected value correspond to different values.

Actual behavior

Question 1,
If you do not enter a value when creating a new creation, you can save it normally. If you enter a value when creating a new creation and then delete it again, an error message will appear.
2024_5_6 16_36_08 video.webm

Question 2.
No error message, the check box cannot be unchecked when the selected value = unselected value
2024_5_6 16_42_19 video.webm

System information

No response

@univer-bot univer-bot bot changed the title [Bug] 数据验证-复选框问题合集 [Bug] Data validation-check box problem collection May 6, 2024
@oumomomo oumomomo self-assigned this May 6, 2024
@oumomomo oumomomo assigned weird94 and unassigned weird94 and oumomomo May 6, 2024
@oumomomo
Copy link
Author

oumomomo commented May 14, 2024

保存自定义值再删除值,复选框会自动勾选上

预期:自定义值被删除后会报错
实际:自定义值被删除后还是可以被保存,并且自动勾选复选框
2024_5_14 11_47_25 video.webm

@weird94
Copy link
Contributor

weird94 commented May 14, 2024

保存自定义值再删除值,复选框会自动勾选上

预期:自定义值被删除后会报错 实际:自定义值被删除后还是可以被保存,并且自动勾选复选框 2024_5_14 11_47_25 video.webm

这个是符合预期的

@univer-bot
Copy link

univer-bot bot commented May 14, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Save the custom value and then delete the value, the checkbox will be automatically checked

Expectation: An error will be reported after the custom value is deleted Actual: The custom value can still be saved after being deleted, and the check box is automatically checked [2024_5_14 11_47_25 video.webm](https://github.com/dream-num /univer/assets/167171356/739e66d0-9e2f-4377-b65f-713a8bdd5c48)

This is in line with expectations

weird94 added a commit that referenced this issue May 15, 2024
…ion (#2233)

* fix: #684 univer-pro

* feat: auto-height

* feat: update

* fix: #2174

* feat: #2162 checkbox ticked and unticked value

* fix: hover-manager-service

* fix: checkbox validator

* feat: lint

* fix: error when delete worksheet

* feat: custom-render event handler
weird94 added a commit that referenced this issue May 21, 2024
* feat: add thread-comment pkg

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: temp

* feat: update

* feat: update

* feat: u

* feat: update

* feat: update

* feat: update

* feat: update

* fix: #2121

* fix: close #2120

* fix: #2114

* fix: #2112

* feat: temp

* feat: update

* feat: support at-input

* feat: ref-range

* feat: update mentions

* feat: user

* feat: update

* feat: update comment

* feat: style update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: rename

* feat: scroller

* feat: update

* feat: update

* feat: update

* feat: update

* fix: #684 univer-pro

* feat: auto-height

* feat: update

* feat: update

* fix: eslint

* feat: remove useless code

* build: fix build error

* chore: fix lockfile

* build: fix deps

* feat: update

* feat: update

* feat: update

* feat: i18n

* feat: add sheet name

* feat: disable undo on resolve comment operation

* feat: update

* fix: #2174

* feat: #2162 checkbox ticked and unticked value

* feat: update

* fix: hover-manager-service

* feat: support copy-paste

* feat: sidebar visible status

* feat: style

* feat: update

* feat: update init

* feat: temp

* feat: update

* feat: update

* fix: checkbox validator

* feat: lint

* fix: error when delete worksheet

* feat: refactor canvas popup service

* feat: update

* feat: lock

* feat: custom-render event handler

* feat: update ref

* fix: copy-paste

* feat: update

* feat: update

* feat: update max-height

* feat: update

* feat: fix delete comment

* fix: #715

* feat: update

* feat: update scroll

* feat: style update

* feat: bugfix

* feat: update

* feat: close sidebar

* fix: cv undo

* feat: update

* feat: render z-index

* feat: code review issue

* feat: transform mentions data

* feat: u

* feat: bugfix

* feat: update

* feat: update

* feat: style & bugfix

* feat: style update

* feat: update

* feat: update

* feat: update

* feat: add thread-comment-data-source-service to support async comment crud

* feat: rename

* feat: build issue

* fix: sort order of comments

* feat: lint

* feat: rename

* feat: rebase dev

---------

Co-authored-by: 白熱 <sonne@asaki.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants