Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BufferGeometry support? #1

Closed
Ben-Mack opened this issue Dec 15, 2017 · 5 comments
Closed

Add BufferGeometry support? #1

Ben-Mack opened this issue Dec 15, 2017 · 5 comments

Comments

@Ben-Mack
Copy link

Thanks for this great library!

But look like this lib hasn't supported BufferGeometry yet, please add support for it because it comes with many benefits and is recommended to use in Three.js.

In my case, using TextBufferGeometry decrease text creation time up to more than 4 times compare to TextGeometry ( from 4s to below 1s )

@looeee
Copy link

looeee commented Mar 17, 2018

@Ben-Mack you're asking for a big update here - looking through the source code basically the whole library would have to be rewritten. I would say that the better approach would be to fork the library and create a new version that supports BufferGeometry yourself, if you have time or interest.

@Ben-Mack
Copy link
Author

@looeee Thanks for your reply! Currently I don't need this lib to working with BufferGeometry, but I need to export the result of it THREE.Geometry to Glb for Facebook.

As I described here: mrdoob/three.js#13397 (comment) THREE.Geometry converted to BufferGeometry then export to GLB got below problem on Facebook:

Vertex COLOR_0 attributes of type RGB are (temporarily) not supported. They must be RGBA

Then as mrdoob reply at mrdoob/three.js#13397 (comment) , I thought it will be just a quick fixes on Three.js library?

@looeee
Copy link

looeee commented Mar 17, 2018

Vertex COLOR_0 attributes of type RGB are (temporarily) not supported. They must be RGBA

As they say, it's temporary. Facebook's support of glTF is very new and not complete yet.

To clarify, this is not an issue wth three.js, it's an issue that Facebook needs to fix.

In the meantime, perhaps you can remove the color attribute from your geometry before exporting?

@mjmaurer
Copy link

mjmaurer commented Apr 1, 2021

Did anyone end up forking? Three r125 defaults to BufferedGeometry for all *Geometry classes [1]. Might be a nice thing to add to the README as well.

[1] - https://discourse.threejs.org/t/three-geometry-will-be-removed-from-core-with-r125/22401

mjmaurer added a commit to mjmaurer/threejs-mesh-modifiers that referenced this issue Apr 1, 2021
@drawcall
Copy link
Owner

drawcall commented Jun 7, 2021

The latest version of threejs-mesh-modifiers already supports BufferGeometry, because three.js removes THREE.Geometry

@drawcall drawcall closed this as completed Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants