Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

So, 4.0.0 release requires rails 5.0 or 5.2? #873

Open
biow0lf opened this issue Feb 5, 2020 · 1 comment
Open

So, 4.0.0 release requires rails 5.0 or 5.2? #873

biow0lf opened this issue Feb 5, 2020 · 1 comment

Comments

@biow0lf
Copy link
Contributor

biow0lf commented Feb 5, 2020

Hi,

In README.md:

As of version 4.0.0, Draper only officially supports Rails 5.2

But, in draper.gemspec:

s.add_dependency 'activesupport', '>= 5.0'
s.add_dependency 'actionpack', '>= 5.0'
s.add_dependency 'activemodel', '>= 5.0'

So, how it right? README.md or gemspec?

@codebycliff
Copy link
Collaborator

Great point. My intent here was to drop official support for Rails < 5.2 as Rails no longer supports versions less than 5.2. However, I didn't want to prevent people from using the gem on older versions of Rails as there are currently no known issues preventing you from doing so. Does that make sense or am I crazy? I lean toward just updating the README to explain that better, but certainly could change the gemspec if that makes more sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants