Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart contract still builds and creates even when creating the transaction type fails and returns a 500 #225

Open
cheeseandcereal opened this issue Oct 25, 2019 · 0 comments

Comments

@cheeseandcereal
Copy link
Contributor

  • Dragonchain Version: 4.1.0
  • Entrypoint: Webserver

Right now, when creating a smart contract, if the transaction type fails to create for an unexpected reason, the webserver will return a 500 and the associated transaction type fails to create, but the smart contract will still be built and added to the chain (making it unusable without the transaction type) regardless.

If the transaction type fails to create, then the smart contract should not be built.

Currently if you run into this bug, you must manually remove the contract that was created.

You can see this unexpected behavior when reproducing #224, but the same issue would likely occur with any unexpected failure to create the transaction type, such as storage errors, which should be handled better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant