Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Typescript support issues #42

Closed
alexsyo opened this issue Dec 5, 2018 · 9 comments
Closed

Bug: Typescript support issues #42

alexsyo opened this issue Dec 5, 2018 · 9 comments

Comments

@alexsyo
Copy link

alexsyo commented Dec 5, 2018

I get An index signature parameter type cannot be a union type. Consider using a mapped object type instead. when trying to use this library with typescript.

Apparently, the issue is coming from the labels in the index.d.ts file for the media object (line 119).
Here there is a discussion about this --> microsoft/TypeScript#24220

Is it just me or am I missing something in the configuration?

@dragma
Copy link
Owner

dragma commented Dec 5, 2018

This is a mission for @hector-del-rio ! :)

@hector-del-rio
Copy link
Contributor

Which version of TypeScript are you using?

@hector-del-rio
Copy link
Contributor

I believe #43 will fix this.

@alexsyo
Copy link
Author

alexsyo commented Dec 5, 2018

TypeScript 3.2.1.
Yes I think that PR fixes it, Thank you!

@zaguiini
Copy link

zaguiini commented Dec 19, 2018

I'm still getting the error.

Typescript version: 3.2.2
styled-bootstra-grid version: 2.0.1

@dragma
Copy link
Owner

dragma commented Dec 20, 2018

I'm sorry. There is a big update coming, but there are some issues that needs to be corrected before.
Plus this is a hard period right now for working on side projects. I'll keep you in touch here when there is any update.

@zaguiini
Copy link

Thanks for the feedback. I guess I'll maintain those @ts-ignores for a while :(

@dragma
Copy link
Owner

dragma commented Feb 8, 2019

New version is comming this weekend !

@dragma
Copy link
Owner

dragma commented Feb 12, 2019

I released V3 today. Tell me if this resolves your problem ! :)

@dragma dragma closed this as completed Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants