Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delay property to the rateOf function #46

Open
hemilpanchiwala opened this issue Jun 16, 2020 · 1 comment
Open

Add delay property to the rateOf function #46

hemilpanchiwala opened this issue Jun 16, 2020 · 1 comment
Assignees
Labels
gsoc SBML-l3v2 Features of SBML Level 3 Version 2

Comments

@hemilpanchiwala
Copy link
Member

Currently, whenever the rateOf is defined inside the delay tag for any of the SBML model then it does not take that delay into account and just provides the rateOf values as the time proceeds.

Issue found while simulating the model 1400, 1401 from SBML Test Suite.

Screenshot of simulation result for the model 1400:
Screenshot from 2020-06-17 00-36-35

Here, for the parameter with id P1, the assignment rule is defined to have a delay of 1 in calculating the rateOf while for the parameter with id P0; its only calculating rateOf with time. But the results show that P0 and P1 are just having the same values all the time, which means the delay is not considered here.

@hemilpanchiwala hemilpanchiwala added gsoc SBML-l3v2 Features of SBML Level 3 Version 2 labels Jun 16, 2020
@hemilpanchiwala hemilpanchiwala self-assigned this Jun 16, 2020
@hemilpanchiwala
Copy link
Member Author

hemilpanchiwala commented Jun 16, 2020

This occurs as currently whenever the rateOf function is called it just gets the value from the changeRate array at that time, instead, there should be something like if I can make an ASTNodeValue object of that value from changeRate array as a REAL nodeType and just run compileDouble method by passing time and delay then everything should run fine, i.e., delays will be considered.

@draeger, @matthiaskoenig
What do you think about it? And if yes, can I convert a double value (a value from changeRate array) to an ASTNodeValue instance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gsoc SBML-l3v2 Features of SBML Level 3 Version 2
Projects
None yet
Development

No branches or pull requests

1 participant