Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back strategy for headerless PDB files. #122

Closed
OWissett opened this issue Apr 17, 2024 · 2 comments
Closed

Fall back strategy for headerless PDB files. #122

OWissett opened this issue Apr 17, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@OWissett
Copy link
Collaborator

I have been working with a bunch of PDB files without a header, and found that the identifier isn't parsed since that comes from the HEADER records.

A work around I have is to fallback to using the file name. I think this should be added to the library, since it makes sense to load the identifier from the file name, as you may have multiple different versions of a pdb file with the same HEADER record too.

We can add this to the ReadOptions struct.

@OWissett OWissett self-assigned this Apr 17, 2024
@OWissett OWissett added enhancement New feature or request good first issue Good for newcomers labels Apr 17, 2024
@douweschulte
Copy link
Owner

Sounds like a good plan. To be sure I understand you correctly is it the goal to make the fallback, if there is no header use the file name, default behaviour and make renaming to the file name an option for ReadOptions? That sounds perfect to me. Although a bit of CA should be given to the raw parse methods, because they maybe do not need this fallback support to prevent breaking any existing code where a filename is not obviously available.

@OWissett
Copy link
Collaborator Author

#123 I think this issue is essentially a more extreme version of this issue.

@OWissett OWissett added this to the v0.12.0 milestone May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants