Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add front-end tests for completed pages #110

Open
6 of 11 tasks
douglasnaphas opened this issue Feb 4, 2019 · 2 comments
Open
6 of 11 tasks

Add front-end tests for completed pages #110

douglasnaphas opened this issue Feb 4, 2019 · 2 comments
Assignees
@douglasnaphas
Projects
v2 Passover 2020

Comments

@douglasnaphas
Copy link
Owner

douglasnaphas commented Feb 4, 2019 •
edited

Especially Pick Your Script and Your Room Code. Refactor while doing this.

TODO

  • Explain page
    • Add tests (most importantly, the link)
    • Increase padding on /explain
  • Move some boilerplate to setup.js, based on Enzyme's jest guide and installation guide. This provides an error like "you an only override certain Jest options" from create-react-app, so this is on hold. Actually, it worked. I was tipped off by this.
  • /pick-script
  • MenuAppBar
  • Find out how to not ship test-supporting files like lib/getFourScripts.js.
  • Get rid of un-needed components and files and related tests.
  • Deal with the tests taking ~15s.
  • Factor out dependencies with network interaction
    • Pick Your Script's call to /scripts should be contained in a function that is passed down to it through props from App.
@douglasnaphas douglasnaphas self-assigned this Feb 4, 2019
@douglasnaphas douglasnaphas added this to To do in Sprint 4: 1/29-2/11 via automation Feb 4, 2019
@douglasnaphas douglasnaphas moved this from To do to In progress in Sprint 4: 1/29-2/11 Feb 5, 2019
@douglasnaphas douglasnaphas removed this from In progress in Sprint 4: 1/29-2/11 Feb 12, 2019
@douglasnaphas douglasnaphas added this to To do in Sprint 5: 2/12-2/25 via automation Feb 12, 2019
@douglasnaphas douglasnaphas removed this from To do in Sprint 5: 2/12-2/25 Feb 12, 2019
@douglasnaphas douglasnaphas added this to To do in Sprint 7: 3/12-3/25 via automation Feb 12, 2019
@douglasnaphas douglasnaphas added this to To do in Sprint 8: 3/26-4/8 via automation Feb 24, 2019
@douglasnaphas douglasnaphas removed this from To do in Sprint 7: 3/12-3/25 Feb 24, 2019
@douglasnaphas douglasnaphas removed this from To do in Sprint 8: 3/26-4/8 Mar 31, 2019
@douglasnaphas douglasnaphas added this to To do in Sprint 9: 4/9-4/20 via automation Apr 11, 2019
@douglasnaphas douglasnaphas moved this from To do to In progress in Sprint 9: 4/9-4/20 Apr 12, 2019
@douglasnaphas
Copy link
Owner Author

Tests to add

Multi-page

  1. Refresh. Test what happens when certain props are not supplied.

/play

  1. Submit some libs, check that the submit library function gets called with the correct args

@douglasnaphas douglasnaphas moved this from In progress to To do in Sprint 9: 4/9-4/20 Apr 14, 2019
@douglasnaphas douglasnaphas moved this from To do to In progress in Sprint 9: 4/9-4/20 Apr 20, 2019
@douglasnaphas douglasnaphas added this to To do in v2 Passover 2020 via automation Apr 27, 2019
@douglasnaphas douglasnaphas removed this from In progress in Sprint 9: 4/9-4/20 Apr 27, 2019
@douglasnaphas douglasnaphas added this to To do in July 2019 via automation Jul 7, 2019
@douglasnaphas douglasnaphas moved this from To do to In progress in July 2019 Jul 7, 2019
@douglasnaphas douglasnaphas removed this from In progress in July 2019 Aug 12, 2019
@douglasnaphas douglasnaphas added this to To do in August 2019 via automation Aug 12, 2019
@douglasnaphas douglasnaphas moved this from To do to In progress in August 2019 Aug 12, 2019
@douglasnaphas douglasnaphas added this to To do in September 2019 via automation Sep 2, 2019
@douglasnaphas douglasnaphas removed this from In progress in August 2019 Sep 2, 2019
@douglasnaphas douglasnaphas moved this from To do to In progress in September 2019 Sep 2, 2019
douglasnaphas added a commit to douglasnaphas/madliberationjs that referenced this issue Sep 4, 2019
@douglasnaphas
Streamline NoAuthHomePage render and link tests
ceba4b7 
douglasnaphas/madliberation#110
douglasnaphas added a commit to douglasnaphas/madliberationjs that referenced this issue Sep 4, 2019
@douglasnaphas
Remove unused shallow declarations
e1eb321 
douglasnaphas/madliberation#110
douglasnaphas added a commit to douglasnaphas/madliberationjs that referenced this issue Sep 7, 2019
@douglasnaphas
Refactor Home Page
f1552ce 
douglasnaphas/madliberation#110
douglasnaphas added a commit to douglasnaphas/madliberationjs that referenced this issue Sep 7, 2019
@douglasnaphas
Remove unused Home Pages
eb5e6e7 
douglasnaphas/madliberation#110
douglasnaphas added a commit to douglasnaphas/madliberationjs that referenced this issue Sep 7, 2019
@douglasnaphas
Add tests for /explain
8199b7d 
douglasnaphas/madliberation#110
douglasnaphas added a commit to douglasnaphas/madliberationjs that referenced this issue Sep 7, 2019
@douglasnaphas
Add padding to /explain
0afd0b4 
douglasnaphas/madliberation#110
douglasnaphas added a commit to douglasnaphas/madliberationjs that referenced this issue Sep 7, 2019
@douglasnaphas
Remove hello-world
1fbe50a 
douglasnaphas/madliberation#110
douglasnaphas added a commit to douglasnaphas/madliberationjs that referenced this issue Sep 7, 2019
@douglasnaphas
Do Enzyme setup in setupTests.js
1856fb1 
douglasnaphas/madliberation#110

Based on:
  - https://create-react-app.dev/docs/running-tests#src-setuptestsjs
  - https://airbnb.io/enzyme/docs/guides/jest.html
  = https://airbnb.io/enzyme/docs/installation/
douglasnaphas added a commit to douglasnaphas/madliberationjs that referenced this issue Sep 7, 2019
@douglasnaphas
Remove unused styles
1c74ff7 
douglasnaphas/madliberation#110
douglasnaphas added a commit to douglasnaphas/madliberationjs that referenced this issue Sep 12, 2019
@douglasnaphas
Use JSON instead of strings in PickScript test
aa7e5ed 
douglasnaphas/madliberation#110
douglasnaphas added a commit to douglasnaphas/madliberationjs that referenced this issue Sep 16, 2019
@douglasnaphas
Add a placeholder for testing keys
0237235 
douglasnaphas/madliberation#110
douglasnaphas added a commit to douglasnaphas/madliberationjs that referenced this issue Sep 18, 2019
@douglasnaphas
Add a placeholder for testing keys
e89efae 
douglasnaphas/madliberation#110
douglasnaphas added a commit to douglasnaphas/madliberationjs that referenced this issue Sep 18, 2019
@douglasnaphas
Add a pattern node for a full script row
6b14187 
douglasnaphas/madliberation#110
douglasnaphas added a commit to douglasnaphas/madliberationjs that referenced this issue Sep 24, 2019
@douglasnaphas
Check for the full expected script table
1b115a1 
douglasnaphas/madliberation#110
douglasnaphas added a commit to douglasnaphas/madliberationjs that referenced this issue Sep 24, 2019
@douglasnaphas
Remove placeholders for redundant scripts tests
4fad93e 
douglasnaphas/madliberation#110
douglasnaphas added a commit to douglasnaphas/madliberationjs that referenced this issue Sep 28, 2019
@douglasnaphas
Test script table output with different scripts
4720cdc 
douglasnaphas/madliberation#110
douglasnaphas added a commit to douglasnaphas/madliberationjs that referenced this issue Sep 29, 2019
@douglasnaphas
Click the 3rd script and test that it's clicked
abea54d 
douglasnaphas/madliberation#110
douglasnaphas added a commit to douglasnaphas/madliberationjs that referenced this issue Sep 29, 2019
@douglasnaphas
Add testFewerThanNOfSelecor util
495b850 
douglasnaphas/madliberation#110
douglasnaphas added a commit to douglasnaphas/madliberationjs that referenced this issue Sep 29, 2019
@douglasnaphas
Test that the script selecting function is called
15b2f32 
douglasnaphas/madliberation#110
douglasnaphas added a commit to douglasnaphas/madliberationjs that referenced this issue Sep 29, 2019
@douglasnaphas
Note unnecessary /scripts tests
1676a73 
douglasnaphas/madliberation#110
douglasnaphas added a commit to douglasnaphas/madliberationjs that referenced this issue Sep 29, 2019
@douglasnaphas
Remove console output from testUtils test
9bd83ec 
douglasnaphas/madliberation#110
douglasnaphas added a commit to douglasnaphas/madliberationjs that referenced this issue Sep 29, 2019
@douglasnaphas
Test the script table button link`
b0bd41b 
douglasnaphas/madliberation#110
@douglasnaphas douglasnaphas removed this from In progress in September 2019 Oct 12, 2019
@douglasnaphas douglasnaphas added this to To do in October 2019 via automation Oct 12, 2019
@douglasnaphas douglasnaphas moved this from To do to In progress in October 2019 Oct 12, 2019
douglasnaphas added a commit to douglasnaphas/madliberationjs that referenced this issue Oct 29, 2019
@douglasnaphas
Set up GeneratingRoomCode... for testing
559383d 
douglasnaphas/madliberation#110
@douglasnaphas douglasnaphas added this to To do in November 2019 via automation Nov 2, 2019
@douglasnaphas douglasnaphas removed this from In progress in October 2019 Nov 2, 2019
@douglasnaphas douglasnaphas moved this from To do to In progress in November 2019 Nov 2, 2019
@douglasnaphas
Copy link
Owner Author

douglasnaphas commented Nov 2, 2019 •
edited

Resources

  1. Mocking fetch
  2. Mocking localStorage

@douglasnaphas douglasnaphas removed this from In progress in November 2019 Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@douglasnaphas douglasnaphas

Labels
None yet
Projects
No open projects
v2 Passover 2020
  
To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@douglasnaphas