[4.1.1] updateMetadataForTrack accidentally clears artwork on Android #2287
Comments
|
i can see this in example by just commenting out title and duration in onUpdateCurrentTrackMetadata(). it only messes up when replacing currentIndex Tracks. |
|
Thanks, @lovegaoshi , I will try that tomorrow. Although I am not sure how to get the TP.currentIndex? What is the function I should use for that? :) |
|
await tp. getActiveTrackIndex()
…On Wed, Apr 3, 2024, 2:00 PM DennisdeWitNL ***@***.***> wrote:
Thanks, @lovegaoshi <https://github.com/lovegaoshi> , I will try that
tomorrow. Although I am not sure how to get the TP.currentIndex? What is
the function I should use for that? :)
—
Reply to this email directly, view it on GitHub
<#2287 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZMOVVWNWSNYNDDZDCCFKYTY3RUXPAVCNFSM6AAAAABFVUZR4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZVGU4DEMJYHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
|
@lovegaoshi Unfortunately, both functions render the same issue. This is the code I have used |
|
well, i actually dont see any problem on my end if artist and title are also set. so you're probably looking at a different issue than what i observed, unless you have a repo from the example i'm at a dead end. |
|
Hi @lovegaoshi, yes. We tried this before. You can change the title to ‘foo’, and the artist to ‘foo’, too. If these fields stay the same, the artwork blanks out. When title and artist are regenerated, there’s no problem. What comes to my mind for now is making a workaround that checks if the new info is the same as the old info, before invoking the updateMetadata command. |
|
hmm. still cant reproduce. see if that repo above bugs on your end. |
|
So, for now I have worked my way around this issue, by reading the previous issue once again. Still needs to be solved, but at least I can work around it now. |
|
are you sure you are running tje **example** app following tje instructions
in that folder?
…On Thu, Apr 4, 2024, 12:38 AM DennisdeWitNL ***@***.***> wrote:
So, for now I have worked my way around with this code:
const updateMetadata = async (streamValues) => {
const activeTrack = await TrackPlayer.getActiveTrack();
if (activeTrack?.artist != streamValues.artist && activeTrack?.title != streamValues.title) {
console.log("Updating metadata")
const currentTrack = await TrackPlayer.getActiveTrackIndex();
if (currentTrack == null) {
// getStreamInfoAndTriggerInitTrackPlayer();
} else {
TrackPlayer.updateMetadataForTrack(currentTrack, {
artist: streamValues.artist,
title: streamValues.title,
artwork: streamValues.artwork,
});
}
} else {
console.log("doing nothing")
}
}
It seems it clears out the artwork when the title and artist are still the
same. So I will only update the metadata when all new info is available.
That works fine. :)
Still needs to be solved, but at least I can work around it now.
—
Reply to this email directly, view it on GitHub
<#2287 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZMOVVUASIQ55SYJTE5ZHP3Y3T7OTAVCNFSM6AAAAABFVUZR4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZWGQYTENJSGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
Will check tomorrow. I have had a busy evening, sorry. For my info: did you change something ‘under the hood’ of RNTP that might be on influence of the bug? |
|
Having the same issue as Dennis using a local file: const fetchMetadata = async () => {
await fetch('https://fr2.ah.fm/stats?sid=1&json=1')
.then(data => data.json())
.then(async obj => {
if (obj.songtitle && typeof obj.songtitle === 'string') {
const currentTrack = await TrackPlayer.getActiveTrackIndex();
if (currentTrack !== undefined) {
TrackPlayer.updateMetadataForTrack(currentTrack, {
title: obj.songtitle,
artwork: require('./assets/afterhours-fm.jpg'),
});
}
}
})
.catch(function (error) {
console.log(error);
});
};This is being ran every 5 seconds through: useEffect(() => {
const intervalId = setInterval(() => fetchMetadata(), 5000);
return () => clearInterval(intervalId);
}, []);Initially the artwork will load, but as soon as |
|
@Vashiru Because you are firing the command every few seconds and the artist and title did not change yet. You could first check if the artist and title ar not the same as the values the activeTrack already have. If they are the same, do nothing. If they are not the same, then update the values. Something like that. That's how I worked around this problem. |
|
I think I've found a workaround just now: If I call both TrackPlayer.updateMetadataForTrack(currentTrack, {
title: obj.songtitle,
artwork: require('./assets/afterhours-fm.jpg'),
});
TrackPlayer.updateNowPlayingMetadata({
title: obj.songtitle,
artwork: require('./assets/afterhours-fm.jpg'),
});Edit: but adding your code in as an optimization is probably a good idea. Edit2: The issue is specifically in |
Describe the Bug
Since RC07, updateMetadataForTrack correctly keeps the title and artist, but it clears the artwork on Android. The artwork is an empty square. I do not have this problem with RC06, so it seems the bug was introduced with RC07. I had an issue about this one already: #2103, but I can not reopen the issue and now this issue is off your radar, which is a bad thing.
We are developing for web already, while the artwork in Android isn't even working as intended. It should be fixed, not be stale for a year.
Steps To Reproduce
Use the
updateMetadataForTrackfunction. Even if you use a constant as artwork URL, it still clears the artwork on Android. It retains the title and artist correctly. On iOS, everything works as expected.Code To Reproduce
I used the following code:
This code keeps the artist and title, but it doesn't show the artwork, even though it is an constant. It just renders empty. I do not have this issue with RC06 or lower.
Replicable on Example App?
Yes.
Environment Info:
Paste the results of
npx react-native infoPaste the exact
react-native-track-playerversion you are usingReal device? Or simulator?
On a real device and emulator. Tested on Samsung S22.
What OS are you running?
Android 13 / Android 14
The text was updated successfully, but these errors were encountered: