Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error is thrown when minBuffer is set without maxBuffer also being set #2242

Open
uzegonemad opened this issue Jan 26, 2024 · 2 comments
Open
Labels

Comments

@uzegonemad
Copy link

Describe the Bug
When setting minBuffer, an error is thrown about maxBuffer, even if minBuffer is less than the maxBuffer default.

Exception: The value for maxBuffer should be greater than or equal to minBuffer.

According to the docs, maxBuffer defaults to 50, so anything < 50 shouldn't trigger this error.

Steps To Reproduce
Call setupPlayer with a minBuffer of <50.

Code To Reproduce

TrackPlayer.setupPlayer({
    minBuffer: 5
});

Replicable on Example App?
Haven't tried

Environment Info:
Paste the results of npx react-native info

System:
  OS: macOS 14.2.1
  CPU: (10) arm64 Apple M1 Max
  Memory: 86.11 MB / 32.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 18.19.0
    path: ~/.nvm/versions/node/v18.19.0/bin/node
  Yarn:
    version: 1.22.21
    path: ~/.nvm/versions/node/v18.19.0/bin/yarn
  npm:
    version: 10.2.3
    path: ~/.nvm/versions/node/v18.19.0/bin/npm
  Watchman:
    version: 2023.11.20.00
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods:
    version: 1.14.3
    path: /Users/benjamin/.rbenv/shims/pod
SDKs:
  iOS SDK: Not Found
  Android SDK: Not Found
IDEs:
  Android Studio: 2022.3 AI-223.8836.35.2231.10671973
  Xcode:
    version: /undefined
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.8.1
    path: /usr/bin/javac
  Ruby:
    version: 2.7.7
    path: /Users/benjamin/.rbenv/shims/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.73.2
    wanted: 0.73.2
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: true
  newArchEnabled: false

Paste the exact react-native-track-player version you are using
react-native-track-player ^4.0.1

Real device? Or simulator?
Both

How I can Help
Not sure. At first glance, the code seems to be fine.

@uzegonemad uzegonemad added the Bug label Jan 26, 2024
Copy link
Contributor

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Apr 26, 2024
@uzegonemad
Copy link
Author

Still relevant

@github-actions github-actions bot removed the Stale label Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant