Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Expose isServiceBound / hasInitialized Bool #2241

Open
uzegonemad opened this issue Jan 26, 2024 · 2 comments
Open

[Feature Request] Expose isServiceBound / hasInitialized Bool #2241

uzegonemad opened this issue Jan 26, 2024 · 2 comments

Comments

@uzegonemad
Copy link

What is the need and use case of this feature?
My app has some observed properties / reactions that fire when the app is launched. It isn't feasible to call this code after setupPlayer() has been called because of past design considerations that are difficult to refactor. This leads to player_not_initialized rejections.

It would be great if the Android isServiceBound and iOS hasInitialized bools were exposed so my code could wait for player setup. I think there was a PR/patch for this in past versions

Describe the ideal solution
Add a public function like isPlayerSetup() which returns the related bool.

Describe alternatives you've considered
Right now, I have a wrapper function that calls getPlaybackState() and checks for the status of the promise. Returning the state of the bool seems a little cleaner.

How I can Help
I can probably work up a PR in the next month or so unless someone beats me to it.

Copy link
Contributor

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Apr 26, 2024
@uzegonemad
Copy link
Author

Still relevant

@github-actions github-actions bot removed the Stale label Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant