Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote attach to process doesn't support input variables in pipeArgs #3575

Closed
maxd opened this issue Feb 13, 2020 · 7 comments
Closed

Remote attach to process doesn't support input variables in pipeArgs #3575

maxd opened this issue Feb 13, 2020 · 7 comments
Assignees
Labels

Comments

@maxd
Copy link

maxd commented Feb 13, 2020

Issue Description

Looks like pipeArgs doesn't support VSCode input variables. For example the following configuration:

        "pipeArgs": [
          "-f", "Development.yml", "exec", "-T", "${input:serviceName}"
        ]

...

  "inputs": [
    {
      "type": "pickString",
      "id": "serviceName",
      "description": "Service to Debug",
      "options": [
        "service1",
        "service2"
      ],
      "default": "service1"
    }
  ]


return the following output:

Executing: docker-compose -f Development.yml exec -T ${input:serviceName} sh -s < /Users/xxx/.vscode/extensions/ms-vscode.csharp-1.21.11/scripts/remoteProcessPickerScript

When I run debug in VSCode it doesn't show pop-up dialog to configure input variables and just run debug command.

Steps to Reproduce

  1. Create launch.json with input variable in pipeArgs option
  2. Run debug

Expected Behavior

VSCode should show popup-dialog to choose input variable.

Actual Behavior

VSCode doesn't show popup-dialog to choose input variable.

Logs

OmniSharp log

Executing: docker-compose -f Development.yml exec -T ${input:serviceName} sh -s < /Users/xxx/.vscode/extensions/ms-vscode.csharp-1.21.11/scripts/remoteProcessPickerScript
stderr: No such service: sh

Environment information

VSCode version: 1.41.1
C# Extension: 1.21.11

Mono Information OmniSharp using built-in mono
Dotnet Information .NET Core SDK (reflecting any global.json): Version: 3.1.101 Commit: b377529961

Runtime Environment:
OS Name: Mac OS X
OS Version: 10.13
OS Platform: Darwin
RID: osx.10.13-x64
Base Path: /usr/local/share/dotnet/sdk/3.1.101/

Host (useful for support):
Version: 3.1.1
Commit: a1388f194c

.NET Core SDKs installed:
3.1.100 [/usr/local/share/dotnet/sdk]
3.1.101 [/usr/local/share/dotnet/sdk]

.NET Core runtimes installed:
Microsoft.AspNetCore.App 3.1.0 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 3.1.1 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.NETCore.App 3.1.0 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]
Microsoft.NETCore.App 3.1.1 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]

To install additional .NET Core runtimes or SDKs:
https://aka.ms/dotnet-download

Visual Studio Code Extensions
Extension Author Version
csharp ms-vscode 1.21.11
intellij-idea-keybindings k--kato 0.2.37
vscode-docker ms-azuretools 0.10.0
@maxd
Copy link
Author

maxd commented Feb 21, 2020

So, how do you think is it real to implement support of input variables in this extension? It can significantly simplify debug configuration.

@Soarex16
Copy link

Soarex16 commented Jan 18, 2021

Any progress on this feature?

Relared issue in vscode repo:
microsoft/vscode#89758 (comment)

@gregg-miskelly gregg-miskelly changed the title pipeArgs option doesn't support input variables Remote attach to process doesn't support input variables in pipeArgs Jan 28, 2021
@gregg-miskelly
Copy link
Contributor

@Soarex16 to make sure, you are also asking for this in cases where the attach to process dialog is used?

The only way I can think to fix this is to change how the attach dialog is hooked up in these cases so that instead of working as part of the command, instead the extension will implement resolveDebugConfigurationWithSubstitutedVariables (see microsoft/vscode#87450 for more info) and if configuration is of some new special form it will put up the attach to process quick pick that way.

@Soarex16
Copy link

@Soarex16 to make sure, you are also asking for this in cases where the attach to process dialog is used?

The only way I can think to fix this is to change how the attach dialog is hooked up in these cases so that instead of working as part of the command, instead the extension will implement resolveDebugConfigurationWithSubstitutedVariables (see microsoft/vscode#87450 for more info) and if configuration is of some new special form it will put up the attach to process quick pick that way.

Yes, that's will solve the problem

@gregg-miskelly
Copy link
Contributor

I believe this will be addressed by #4509

@gregg-miskelly
Copy link
Contributor

@WardenGnaw Should this issue be resolved?

@WardenGnaw
Copy link
Contributor

Yep. Tested with a promptString input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants