Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate multiple CV entries in debug directory #105

Open
tmat opened this issue Dec 8, 2017 · 0 comments
Open

Validate multiple CV entries in debug directory #105

tmat opened this issue Dec 8, 2017 · 0 comments

Comments

@tmat
Copy link
Member

tmat commented Dec 8, 2017

We should document what the semantics of multiple CodeView records is in a spec: https://github.com/dotnet/corefx/blob/master/src/System.Reflection.Metadata/specs/PE-COFF.md
I think we should disallow multiple portable CodeView records. Is there a way to distinguish record for native PDB vs. record for managed PDB in the native image? If we can I'd also disallow multiple managed PDB records (or perhaps even multiple native PDB records). If we don't disallow multiple portable records we would need to fix https://github.com/dotnet/corefx/blob/master/src/System.Reflection.Metadata/src/System/Reflection/PortableExecutable/PEReader.cs#L693 to also pick the last one. This would also require update of .NET Framework, so I would rather not do that. There seems to be no point in allowing multiple portable records. If we decide to disallow some combination of CV records, the converter should validate it and report an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant