Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MessagePack Reference Loop Handling #31606

Closed
AllanMichaelsen opened this issue Jan 12, 2020 · 4 comments
Closed

MessagePack Reference Loop Handling #31606

AllanMichaelsen opened this issue Jan 12, 2020 · 4 comments

Comments

@AllanMichaelsen
Copy link

I know there is a thread for handling this with Json ( #29900 ), but the issue also exists with message pack protocol.(MPP)

When switching to binary serialization via MPP there are immediate buffer overflow issues.

Is there a way to handle this with MPP?
@davidfowl
Copy link
Member

There's no message pack implementation built into .NET, you might want to file an issue here https://github.com/neuecc/MessagePack-CSharp/issues

@AllanMichaelsen
Copy link
Author

I know that the .AddMessagePackProtocol uses neuecc, but is it there the issue occurs or is it in the .AddMessagePackProtocol itself?

@davidfowl
Copy link
Member

Yes its a serializer issue.

@GrabYourPitchforks
Copy link
Member

Closing as external. Please use the issue tracker David referenced.

@msftgits msftgits transferred this issue from dotnet/corefx Feb 1, 2020
@dotnet dotnet locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@davidfowl @GrabYourPitchforks @AllanMichaelsen