Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System.Data.SqlClient still uses the non-generic collections #16946

Closed
jamesqo opened this issue Apr 11, 2016 · 1 comment
Closed

System.Data.SqlClient still uses the non-generic collections #16946

jamesqo opened this issue Apr 11, 2016 · 1 comment
Assignees
@saurabh500
Labels
area-System.Data.SqlClient bug
Milestone
1.0.0-rtm

Comments

@jamesqo
Copy link
Contributor

jamesqo commented Apr 11, 2016

A quick GitHub search shows that System.Collections.Specialized and System.Data.SqlClient are the only non-test assemblies still dependent on the non-generic collections. While it's kind of inevitable for the specialized collections since it contains a lot of legacy code, it appears from this PR that we can remove System.Collections.NonGeneric from the SqlClient implementation, since it's not exposed to callers.

This is a tracking issue I'm opening up to remove the dependency from SqlClient.
@justinvp
Copy link
Contributor

I have a PR that's almost ready that removes the dependency.

@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 1.0.0-rtm milestone Jan 31, 2020
@dotnet dotnet locked as resolved and limited conversation to collaborators Jan 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@saurabh500 saurabh500

Labels
area-System.Data.SqlClient bug
Projects
None yet
Milestone
1.0.0-rtm
Development

No branches or pull requests
4 participants
@justinvp @saurabh500 @jamesqo @msftgits