VS crash on invalid options specified in .vbproj files

[tmat]

Handling invalid content of .vbproj files needs to be hardened.

ConvertedVisualBasicProjectOptions constructor may throw various exceptions, which VisualBasicProject.SetCompilerOptions then converts to FailFast.

[Pilchie]

Can you please give some specific examples?

[tmat]

I see at least 3 explicit Throws in the function:

 Select Case options.vbRuntimeKind
                Case VBRuntimeKind.DefaultRuntime
                    runtimes.Add(Path.Combine(compilerHost.GetSdkPath(), "Microsoft.VisualBasic.dll"))

                Case VBRuntimeKind.SpecifiedRuntime
                    If options.wszSpecifiedVBRuntime Is Nothing Then
                        Throw New ArgumentException()
                    End If

                    ' If they specified a fully qualified file, use it
                    If File.Exists(options.wszSpecifiedVBRuntime) Then
                        runtimes.Add(options.wszSpecifiedVBRuntime)
                    Else
                        ' If it's just a filename, try to find it in the SDK path.
                        If options.wszSpecifiedVBRuntime <> Path.GetFileName(options.wszSpecifiedVBRuntime) Then
                            Throw New ArgumentException()
                        End If

                        Dim runtimePath = Path.Combine(compilerHost.GetSdkPath(), options.wszSpecifiedVBRuntime)
                        If File.Exists(runtimePath) Then
                            runtimes.Add(runtimePath)
                        Else
                            Throw New ArgumentException()
                        End If
                    End If
            End Select

[tmat]

Not counting the fact that Path APIs throw if paths contain invalid characters, etc.