Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VB] Remove redundant Call #71818

Closed
tats-u opened this issue Jan 26, 2024 · 3 comments
Closed

[VB] Remove redundant Call #71818

tats-u opened this issue Jan 26, 2024 · 3 comments
Labels
Area-IDE Feature Request Resolution-External The behavior lies outside the functionality covered by this repository
Milestone
Backlog

Comments

@tats-u
Copy link

tats-u commented Jan 26, 2024

Brief description:

Describe your code style rule here.

VB requires Call before method call expressions if the method calls do not start with identifiers.
However, some old-fashioned developers have forced others to add this Call to every method call.
It is mainly because of the compatibility with VBA/VB6 and because they do not know when Call is necessary.

Languages applicable:

Is your analyzer C# only? VB Only? Or Both?

VB Only

Code example that the analyzer should report:

Call SomeClass.SomeMethod(arg1, arg2)
'--
'Call' here can be removed.

A small code snippet that describes a case that the analyzer should report.

Note: the following Calls are necessary:

Call New SomeForm().Show()
Call If(condition, form1, form2).Show()

Additional information:

Any more additional information you would like to add.

Documentation requirements:

When this analyzer is implemented, it must be documented by following the steps at Documentation for IDE CodeStyle analyzers.
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Jan 26, 2024
@tats-u
Copy link
Author

tats-u commented Jan 29, 2024 •
edited

https://sharplab.io/#v2:EYLgxg9gTgpgtADwGwBYA0AbEA3YaAuIAhgM75oAmIA1AD4CSAtgA7T4kAEAygJ5kyMAsACgRAYQylOAMQgQRHRdwCuwDgFkY+ABYQKACgrAMHAIKcAIhFUYYaDhRhgzlpwEtGRDAEoFS/2JeJpo6egBM+r7C/gFBGjAAdCG6FBFRMUqBGME8ElJJWikAzJF+GVkmAEJEUAnVAF6l0RkcFRwAclwAjAmdYXVE9QkAisoITS0cZTHJ4RMtmgWhqfMZ6rmSJCRLxasx1bUNe/6dPX0DQ6Pj6S3TsdkdMADuHAeRI2PHShYeHEQcAF4OAA7Z6vGpfRQ/RgcNRA0EvN43cpxfT/aiw7wfa53TJxNwAM30VhsiXoJHaRHahmM3nsRHswCxVz2AFFgRQVMBplxVPFlmlpuzObzuc1FFxtDUYCK+bMKCVkRxhVyRDAORwwJsSCJxNrwVAeVLYLK1EclSrRTy+SyLRqreKOAAFGxuZyS6WcgDyzBgUCI+Gg1H0JnMBvsUBcsJq3ijwBquMUACUtMooMCOBghRqfX6A9ARCq8ltdcJKYwYCRmEQwDAOt1elwwtN1HplLZwfVE1yOLbu5bVNnOa2KO2YIWNeXK9Xa0A===

var member = callStateMent.Invocation;
while (true)
{
    switch (member)
    {
        case InvocationExpression:
        case SimpleMemberAccessExpression:
            member = member.Expression;
            break;
        case Identifier:
        case MeExpression:
        case MyBaseExpression:
        case MyClassExpression:
        // etc.
            return "Call can be removed";
        default:
            return "Call is mandatory";
    }
}

@tats-u tats-u mentioned this issue Apr 25, 2024
Closed
4 tasks
@tats-u
Copy link
Author

tats-u commented Apr 26, 2024

https://learn.microsoft.com/en-us/dotnet/visual-basic/language-reference/statements/call-statement#remarks

@genlu genlu removed the untriaged Issues and PRs which have not yet been triaged by a lead label Apr 30, 2024
@genlu genlu added this to the Backlog milestone Apr 30, 2024
@genlu genlu added the Resolution-External The behavior lies outside the functionality covered by this repository label Apr 30, 2024
@genlu
Copy link
Member

genlu commented Apr 30, 2024

@tats-u thanks for your feedback and spending time work on a solution. But as mentioned from the discussion in the linked PR, we believe this functionality would be more suitable as a separate analyzer outside of Roslyn.

@genlu genlu closed this as completed Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-IDE Feature Request Resolution-External The behavior lies outside the functionality covered by this repository
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Implement analyzer/fixer: remove unnecessary Call keyword from Call statement tats-u/roslyn
2 participants
@genlu @tats-u