Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix "extension" for "extension method" in Japanese must be "拡張", not "拡張子" #73175

Open
tats-u opened this issue Apr 22, 2024 · 4 comments
Labels
Area-IDE Tenet-Localization Some piece of UI isn’t localized, often due to hard-coding of strings or other visible elements.

Comments

@tats-u
Copy link

tats-u commented Apr 22, 2024

Repo URL where the string lives

https://github.com/dotnet/roslyn

File Name

https://github.com/dotnet/roslyn/blob/main/src/Features/CSharp/Portable/xlf/CSharpFeaturesResources.ja.xlf
https://github.com/dotnet/roslyn/blob/main/src/Features/VisualBasic/Portable/xlf/VBFeaturesResources.ja.xlf

Resource ID

  • extension (C#)
  • awaitable_extension (C#)
  • Awaitable_Extension (VB)

English String

extension
awaitable, extension
Awaitable, Extension

Current Translation

拡張子
待機可能、拡張子
待機可能、拡張子

Suggested Translation

拡張
待機可能、拡張
待機可能、拡張

Note: "・" instaed of "、" is preferred in my opinion because "・" is often used as &.

待機可能・拡張

Language

Japanese

Why Fix is needed

"拡張子" means file extension.
"Extension method" is translated into "拡張メソッド".


Roslyn Team Instructions

A Roslyn team member will file a bug through https://aka.ms/ceLocBug which the translation team will consider.

Internal Tracking Issue: https://ceapex.visualstudio.com/CEINTL/_workitems/edit/968500

@tats-u tats-u added Area-Infrastructure Tenet-Localization Some piece of UI isn’t localized, often due to hard-coding of strings or other visible elements. labels Apr 22, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Apr 22, 2024
@tats-u tats-u changed the title Prefix of "extension method" in Japanese must be "拡張", not "拡張子" Prefix "extension" for "extension method" in Japanese must be "拡張", not "拡張子" Apr 22, 2024
@tats-u
Copy link
Author

tats-u commented Apr 22, 2024

Shall I send a PR to fix this? I have already pushed its content to my forked repo.

@huoyaoyuan
Copy link
Member

huoyaoyuan commented Apr 22, 2024

This may be applicable to other languages too.
Please inform the localization teams to create a name for the extension feature.

Is this about the existing extension method feature?

@tats-u
Copy link
Author

tats-u commented Apr 23, 2024

Yes. It is used as annotating that the currently suggested method candidate is an extension one.

image

It is used as only this purpose.

https://sourceroslyn.io/#Microsoft.CodeAnalysis.CSharp.Features/Microsoft.CodeAnalysis.CSharp.CSharpFeaturesResources.cs,433053edc5e6d83d,references
https://sourceroslyn.io/#Microsoft.CodeAnalysis.VisualBasic.Features/Microsoft.CodeAnalysis.VisualBasic.VBFeaturesResources.vb,b09b7e384dd7db25,references

Machine translation of 2 "extension"s:

image
image
image

Chinese / Korean's translations of the xlf correspond to the second sentence ("extension method" - "method"), not the first ("file extension" - "file").

Description for Chinese:

Japanese/Korean: "扩张" + "子" (file extension) / "扩张" + method (extension method)
Japanese xlf: 扩张子
Korean xlf: 扩张
Chinese: "扩展" (+ "名") (file extension) / "扩展" + "方法" (extension method)
Chinese xlf: 扩展

Han notation for Korean word for file extension: https://namu.wiki/w/%ED%99%95%EC%9E%A5%EC%9E%90

@genlu genlu added help wanted The issue is "up for grabs" - add a comment if you are interested in working on it and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 30, 2024
@genlu
Copy link
Member

genlu commented Apr 30, 2024

@tats-u thanks for you feedback and I filed an internal bug for the localization team.

@genlu genlu added Area-IDE and removed help wanted The issue is "up for grabs" - add a comment if you are interested in working on it Area-Infrastructure labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Tenet-Localization Some piece of UI isn’t localized, often due to hard-coding of strings or other visible elements.
Projects
None yet
Development

No branches or pull requests

3 participants