Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce formatting of compiler generated code #44130

Closed
sharwell opened this issue May 11, 2020 · 2 comments
Closed

Enforce formatting of compiler generated code #44130

sharwell opened this issue May 11, 2020 · 2 comments
Assignees
Labels
Area-Infrastructure Concept-Continuous Improvement Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented

Comments

@sharwell
Copy link
Member

#43998 updates the formatting of generated code to match the form produced by the formatter. We should run dotnet-format during the correctness leg to enforce that these files remain formatted if/when changes are made in the future.

Blocked on dotnet/format#670

@Youssef1313
Copy link
Member

Youssef1313 commented Dec 25, 2020

@sharwell This shouldn't be blocked any more. dotnet/format#673


We should run dotnet-format during the correctness leg to enforce that these files remain formatted if/when changes are made in the future.

I even see that you already have the --include-generated in your PR #43998. Is there anything left for this issue?

@sharwell
Copy link
Member Author

I think this was already implemented in f309d21

@sharwell sharwell added Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented and removed Blocked labels Dec 26, 2020
@sharwell sharwell self-assigned this Dec 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure Concept-Continuous Improvement Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Projects
None yet
Development

No branches or pull requests

2 participants