Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All of the CollectionView samples need to be updated so the CV is inside a Grid not a StackLayout #467

Open
PureWeen opened this issue May 3, 2024 · 0 comments · May be fixed by #468
Open

All of the CollectionView samples need to be updated so the CV is inside a Grid not a StackLayout #467

PureWeen opened this issue May 3, 2024 · 0 comments · May be fixed by #468

Comments

@PureWeen
Copy link
Member

PureWeen commented May 3, 2024

https://github.com/dotnet/maui-samples/blob/main/8.0/UserInterface/Views/CollectionViewDemos/CollectionViewDemos/Views/Swipe/VerticalListSwipeContextItemsPage.xaml#L7

StackLayouts will cause the CollectionView to take up infinite space. What this means is that the CV won't be virtualized at all. if a CV has 100 items it'll render 100 items which is really bad for performance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace all StackLayout with Grid or Horizontal-/VerticalStackLayout dotnet/maui-samples
1 participant
@PureWeen