Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When matching all files don't rely on FileMatcher #864

Merged
merged 1 commit into from Nov 16, 2020

Conversation

JoeRobich
Copy link
Member

@JoeRobich JoeRobich commented Nov 16, 2020

When Including "**/*.*" (All files in all directories), the file matcher doesn't return matches for valid filenames. This PR skips checking the file matcher when we are matching all files.

Resolves #809

@JoeRobich
Copy link
Member Author

Opened dotnet/runtime#44767 to track this bug with FileSystemGlobbing.Matcher.

@JoeRobich JoeRobich merged commit acb1b73 into dotnet:master Nov 16, 2020
@JoeRobich JoeRobich deleted the fix-file-matcher branch March 5, 2021 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Are roslyn analyzers working?
2 participants