Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve folder performance #760

Merged
merged 6 commits into from Aug 15, 2020
Merged

Improve folder performance #760

merged 6 commits into from Aug 15, 2020

Conversation

JoeRobich
Copy link
Member

Improve #757. This PR does a few things.

  • Updates dependency versions
  • No longer take a hit for logging information about .NET Sdk or loading MSBuild if using the --folder option
  • Use the FileGlobMatcher to determine the list of matched file paths when loading the folder workspace once. Project loaders will filter by extension.
  • Only enumerate the potential .editorconfig file paths once for the FolderWorkspace and pass to the ProjectLoaders.

@JoeRobich JoeRobich closed this Aug 15, 2020
@JoeRobich JoeRobich reopened this Aug 15, 2020
@JoeRobich JoeRobich merged commit 7164b28 into master Aug 15, 2020
@JoeRobich JoeRobich deleted the improve-folder-performance branch August 16, 2020 01:27
@JoeRobich JoeRobich mentioned this pull request Aug 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmarolf jmarolf jmarolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JoeRobich @jmarolf