Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter analyzers by project language before running #725

Merged
merged 1 commit into from Jul 6, 2020

Conversation

JoeRobich
Copy link
Member

No description provided.

@jmarolf
Copy link
Contributor

jmarolf commented Jul 6, 2020

I need to write tests for this

@JoeRobich JoeRobich merged commit 12b27cc into dotnet:master Jul 6, 2020
@@ -193,13 +200,18 @@ static void LogDiagnosticLocations(Solution solution, IEnumerable<Diagnostic> di

return solution;

static ImmutableDictionary<string, ImmutableArray<DiagnosticAnalyzer>> CreateAnalyzerMap(
static ImmutableDictionary<string, ImmutableDictionary<string, ImmutableArray<DiagnosticAnalyzer>>> CreateAnalyzerMap(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get it, but also this dictionary will have max two entries that you care about, there are no efforts in the works to generalize roslyn analyzers/fixers to more languages, consider just making the dictionary value a pair of arrays for CS and VB respectively.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look at mr. glass-half-empty thinking we won't support hundreds of lanuguages

@JoeRobich JoeRobich deleted the filter-analyzers-by-language branch March 5, 2021 21:02
vdurante pushed a commit to vdurante/format that referenced this pull request Feb 29, 2024
…uage

Filter analyzers by project language before running
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants