Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run compiler diagnostics if any active code fix declares support for them #398

Closed
sharwell opened this issue Oct 18, 2019 · 3 comments · Fixed by #750
Closed

Run compiler diagnostics if any active code fix declares support for them #398

sharwell opened this issue Oct 18, 2019 · 3 comments · Fixed by #750
Labels
Feature Request This issue is requesting an enhancement or new feature

Comments

@sharwell
Copy link
Member

If any active code fix contains a CS* (C#) or BC* (Visual Basic) diagnostic ID in the set of supported diagnostics, we need to make sure these compiler diagnostics are gathered.

Filed as a follow-up to #281

@sharwell
Copy link
Member Author

/cc @jmarolf

@jmarolf
Copy link
Contributor

jmarolf commented Oct 18, 2019

right, we will. my understanding is that today no code style warning that we ship needs this. We'll also need to investigate how poorly this effects performance

@sharwell
Copy link
Member Author

I believe we have some code fixes in place for fixing some compiler warnings. It should be a straightforward change to check the declared diagnostic IDs though to make sure we are ready for a case if/when a user adds a code fix to the mix that uses them (e.g. a code fix that adds NRT annotations to explicitly-typed local variables).

@JoeRobich JoeRobich added the Feature Request This issue is requesting an enhancement or new feature label Mar 17, 2020
@JoeRobich JoeRobich linked a pull request Aug 9, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request This issue is requesting an enhancement or new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants