Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precompiled queries: calculate the NRT status of complex expressions in the funcletizer #33508

Open
Tracked by #29754
roji opened this issue Apr 10, 2024 · 0 comments
Open
Tracked by #29754

Comments

@roji
Copy link
Member

roji commented Apr 10, 2024

Our current SQL pregeneration mechanism (#29753) takes into account the nullability of reference type parameters; that is, if a reference type variable is captured by the query, and that variable is annotated as non-nullable, our SQL generation takes that into account, generating optimal SQL (and also reducing the number of required SQL permutations).

However, the funcletizer currently only does this for directly captured variables, and notfor larger expressions composed on top of a captured variable (e.g. Where(b => b.Name == foo + "Bla")). Doing this would require bubbling nullability information up the tree via State, and knowing to correctly know to combine operand nullabilities per expression type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant