Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential addition of an OrderedDictionary<TKey, TValue> type #220

Open
alexrp opened this issue Jan 30, 2024 · 6 comments
Open

Potential addition of an OrderedDictionary<TKey, TValue> type #220

alexrp opened this issue Jan 30, 2024 · 6 comments
Labels
enhancement New feature or request
Projects

Comments

@alexrp
Copy link

alexrp commented Jan 30, 2024

Context: dotnet/runtime#24826 (especially the last 10 or so comments)

Do you think it would make sense for .NEXT to include @TylerBrinkley's OrderedDictionary<TKey, TValue> implementation in DotNext.Collections? (Assuming Tyler takes no issue with this, of course.) It seems like there's high demand for this type but low appetite for prioritizing it from the .NET team, and it's only currently available in an unmaintained, pre-release, and deprecated package.

@TylerBrinkley
Copy link

TylerBrinkley commented Jan 30, 2024

It's MIT licensed so please do with it what you will. Personally, outside of including it in the BCL I think it would probably be used more in a more collection focused library. I think more people would be able to discover its existence and would be more willing to take a dependency on it than a more general purpose library like this. -Edit (After re-reading this I guess I really like the word "more" 😄)

@alexrp
Copy link
Author

alexrp commented Jan 30, 2024

I think more people would be able to discover its existence and would be more willing to take a dependency on it than a more general purpose library like this.

The only general purpose collections library that immediately comes to mind here is C5, but that seems to be unmaintained these days... 🤔

One could also imagine a DotNext.Collections package, but at that point I might be asking too much of @sakno. 👀

@sakno sakno added the enhancement New feature or request label Jan 30, 2024
@sakno sakno added this to Opened in Core via automation Jan 30, 2024
@sakno
Copy link
Collaborator

sakno commented Jan 30, 2024

On the one hand, I never tried to reach the goal to incorporate reusable data structures to .NEXT such as trees, collections, etc. From the other side, the library has specialized collections such as typed maps, concurrent cache, etc. Also, there is very similar discussion and proposal: #163. And it was rejected.

@alexrp
Copy link
Author

alexrp commented Jan 31, 2024

If you don't think it belongs in .NEXT, that's totally fine. This was just the first possibility that came to mind while trying to think of a potential home for it.

@sakno
Copy link
Collaborator

sakno commented Jan 31, 2024

Let's keep this issue open for now. I don't want to be a sole decision maker, .NEXT is an open-source project and community opinion matters.

@alexrp
Copy link
Author

alexrp commented Apr 10, 2024

Still has to go through API review, but I think it's safe to say that this won't be needed after all: dotnet/runtime#24826 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Core
  
Opened
Development

No branches or pull requests

3 participants