Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetCompletions should check exit code of invoked application #2137

Open
tmds opened this issue Mar 31, 2023 · 0 comments · May be fixed by #2160
Open

GetCompletions should check exit code of invoked application #2137

tmds opened this issue Mar 31, 2023 · 0 comments · May be fixed by #2160
Labels
Area-Completions Related to support for tab completion bug Something isn't working help wanted Extra attention is needed

Comments

@tmds
Copy link
Member

tmds commented Mar 31, 2023

This code should probably check the exit code and not consider standard output to be completions when it is non-zero:

command-line-api/src/System.CommandLine.Suggest/SuggestionStore.cs

Lines 47 to 50 in 403234a

if (readToEndTask.Wait(timeout))
{
result = readToEndTask.Result;
}

cc @jonsequitur @adamsitnik
@jonsequitur jonsequitur added bug Something isn't working Area-Completions Related to support for tab completion help wanted Extra attention is needed labels Mar 31, 2023
@baradgur baradgur linked a pull request Apr 11, 2023 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Completions Related to support for tab completion bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SuggestionStore::GetCompletions to check exit code of invoked applica… baradgur/command-line-api
2 participants
@jonsequitur @tmds