Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workarounds for @inherits Page<TModel> are causing spooky issues #8193

Closed
rynowak opened this issue Mar 4, 2019 · 3 comments
Closed

Workarounds for @inherits Page<TModel> are causing spooky issues #8193

rynowak opened this issue Mar 4, 2019 · 3 comments
Assignees
@ajaybhargavb
Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed
Milestone
3.0.0-preview4

Comments

@rynowak
Copy link
Member

rynowak commented Mar 4, 2019 •
edited

There is some WIERD stuff going on with using the type object in components.

I suspect this is due to one of the various workarounds that's in place to allow you to write @inherits Foo in _ViewImports.cshtml without a compiler error. I've never understood what's being done for this case and why it's the right solution - and I guess it's time for me to dig into this area.

This is breaking components and my heart. This is in the generated code.

image

There's no TModel in this class, the dictionary is defined as Dictionary<object, ValidationMessageStore>.
@rynowak rynowak changed the title Workarounds for @inherits Page<TModel> are causing UX issues Workarounds for @inherits Page<TModel> are causing spooky issues Mar 4, 2019
@rynowak
Copy link
Member Author

rynowak commented Mar 4, 2019 •
edited

Level of spookiness

image

@muratg muratg added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Mar 4, 2019
@rynowak rynowak added the Spooky label Mar 4, 2019
@mkArtakMSFT mkArtakMSFT added area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. 1 - Ready labels Mar 5, 2019
@mkArtakMSFT mkArtakMSFT added this to the 3.0.0-preview5 milestone Mar 6, 2019
@mkArtakMSFT mkArtakMSFT added this to Triage in Blazor via automation Mar 6, 2019
@mkArtakMSFT
Copy link
Member

@rynowak, if this is something @ajaybhargavb can handle, please reassign.

@danroth27 danroth27 assigned ajaybhargavb and unassigned rynowak Mar 11, 2019
@danroth27
Copy link
Member

We think support for _Imports.razor will help here: #6374

@danroth27 danroth27 moved this from Triage to To do in Blazor Mar 11, 2019
@ajaybhargavb ajaybhargavb mentioned this issue Mar 26, 2019
Merged
@ajaybhargavb ajaybhargavb moved this from To do to In progress in Blazor Mar 26, 2019
Blazor automation moved this from In progress to Done Mar 27, 2019
@ajaybhargavb ajaybhargavb added Done This issue has been fixed and removed 2 - Working labels Mar 27, 2019
@mkArtakMSFT mkArtakMSFT removed area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels May 9, 2019
@dotnet dotnet locked as resolved and limited conversation to collaborators Dec 3, 2019
@jaredpar jaredpar removed this from Done in Blazor Jan 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ajaybhargavb ajaybhargavb

Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed
Projects
None yet
Milestone
3.0.0-preview4
Development

No branches or pull requests
5 participants
@rynowak @ajaybhargavb @muratg @danroth27 @mkArtakMSFT