Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component compilation support needs to add diagnostics for markup errors #6217

Closed
rynowak opened this issue Jan 2, 2019 · 3 comments
Closed

Component compilation support needs to add diagnostics for markup errors #6217

rynowak opened this issue Jan 2, 2019 · 3 comments
Assignees
@ajaybhargavb
Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed
Milestone
3.0.0-preview4

Comments

@rynowak
Copy link
Member

rynowak commented Jan 2, 2019

The Blazor compiler adds diagnostics for things like missing end tags, and mismatched start/end tags. We don't have that support yet for the new component compiler.

This should probably done in the IR lowering phase.

Please find a few skipped tests in the aspnet/AspNetCore-Tooling repo that refer to this issue.
@DNF-SaS
Copy link

DNF-SaS commented Jan 2, 2019

@rynowak General Question about the repo-merge of Blazor into the AspNetCore-Repo: how can one distinct issues related to blazor from all the other ones? (in this case, this one was only found because I knew that you're closely related to Blazor - looking at labels/projects/whatever, I don't see any blazor-specific classifier)
Sorry for being off-topic and thanks for your answer!

@rynowak
Copy link
Member Author

rynowak commented Jan 2, 2019

Thanks for asking, I think we'll probably end up using a label like area-Components or area-Blazor. Right now it's still the holidays here so the dust hasn't quite settled yet 😆

@rynowak rynowak added this to To do in Blazor via automation Jan 2, 2019
@rynowak
Copy link
Member Author

rynowak commented Jan 2, 2019

You can also look at https://github.com/orgs/aspnet/projects/19 where we're tracking the components productization work

@Eilon Eilon added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jan 2, 2019
@mkArtakMSFT mkArtakMSFT added this to the 3.0.0-preview3 milestone Jan 16, 2019
@SteveSandersonMS SteveSandersonMS added the area-blazor Includes: Blazor, Razor Components label Feb 6, 2019
@mkArtakMSFT mkArtakMSFT assigned ajaybhargavb and unassigned rynowak Feb 22, 2019
@mkArtakMSFT mkArtakMSFT added bug This issue describes a behavior which is not expected - a bug. 1 - Ready labels Feb 22, 2019
@danroth27 danroth27 mentioned this issue Mar 15, 2019
Closed
@ajaybhargavb ajaybhargavb mentioned this issue Mar 21, 2019
Merged
Blazor automation moved this from To do to Done Mar 21, 2019
@danroth27 danroth27 added Done This issue has been fixed and removed 2 - Working labels Apr 12, 2019
@mkArtakMSFT mkArtakMSFT removed area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels May 9, 2019
@dotnet dotnet locked as resolved and limited conversation to collaborators Dec 3, 2019
@jaredpar jaredpar removed this from Done in Blazor Jan 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ajaybhargavb ajaybhargavb

Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed
Projects
None yet
Milestone
3.0.0-preview4
Development

No branches or pull requests
7 participants
@Eilon @SteveSandersonMS @rynowak @ajaybhargavb @danroth27 @DNF-SaS @mkArtakMSFT