Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please consider splitting the AzureAD package apart to reduce dependencies #6029

Closed
mattjohnsonpint opened this issue Dec 19, 2018 · 3 comments
Labels
area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer feature-AADIntegration This issue is related to Azure AD integration

Comments

@mattjohnsonpint
Copy link

I have a lightweight ASP.NET Core Web API project. It has no front end, and thus doesn't need most of what is bundled with the Microsoft.AspNetCore.Mvc package. I can generally use Microsoft.AspNetCore.Mvc.Core package instead.

Except that I need AAD authentication, and when I pull in Microsoft.AspNetCore.Authentication.AzureAD.UI it takes Microsoft.AspNetCore.Mvc as a dependency...

Looking through the code, it seems like there are some controllers and pre-compiled Razor views being included, so I understand why you need the full Mvc package to support those.

It would be great if you could split out the core AAD auth from the UI components, such that those of us who don't need the UI don't need to take the dependency on the big Mvc package. Something like this perhaps:

  • Microsoft.AspNetCore.Authentication.AzureAD.UI
    • Microsoft.AspNetCore.Mvc
    • Microsoft.AspNetCore.Authentication.AzureAD.Core
      • Microsoft.AspNetCore.Authentication.Cookies
      • Microsoft.AspNetCore.Authentication.JwtBearer
      • Microsoft.AspNetCore.Authentication.OpenIdConnect

Thanks.

@aspnet-hello aspnet-hello added area-identity Includes: Identity and providers feature-AADIntegration This issue is related to Azure AD integration labels Dec 19, 2018
@mattjohnsonpint mattjohnsonpint changed the title Please consider splitting this package apart to reduce dependencies Please consider splitting the AzureAD package apart to reduce dependencies Dec 22, 2018
@blowdart blowdart added area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer and removed area-identity Includes: Identity and providers labels Jan 3, 2019
@Eilon
Copy link
Member

Eilon commented Jan 3, 2019

Closing because there are no plans to make any changes to this. The UI part is the bulk of what's in this feature, so if we split that out, there would be almost nothing left.

@Eilon Eilon closed this as completed Jan 3, 2019
@mattjohnsonpint
Copy link
Author

@Eilon - It is still useful without the UI views for WebAPI projects. In ours, I have:

            services.AddAuthentication(AzureADDefaults.AuthenticationScheme)
                .AddAzureAD(options => Configuration.Bind("AzureAd", options))
                .AddAzureADBearer(options => Configuration.Bind("AzureAd", options));

How would I do the equivalent without the Microsoft.AspNetCore.Authentication.AzureAD.UI package?

To unblock my team, I've temporarily copied the source locally and removed the UI components. It works well, but now this code is out-of-band for future maintenance. It would be good if it was built this way naturally.

@Eilon
Copy link
Member

Eilon commented Jan 27, 2019

@mj1856 understood, but at this time there are still no plans for this due to general lack of demand, so the priority is just too low.

@dotnet dotnet locked as resolved and limited conversation to collaborators Dec 3, 2019
This issue is being transferred. Timeline may not be complete until it finishes.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer feature-AADIntegration This issue is related to Azure AD integration
Projects
None yet
Development

No branches or pull requests

4 participants