Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

although EF Core Samples are all TFM 8.0, some MS packages are still only 7.0 #4611

Open
DickBaker opened this issue Jan 5, 2024 · 3 comments
Milestone

Comments

@DickBaker
Copy link
Contributor

there are 90 individual projects in the EntityFramework.Docs\samples\core and they are all <TargetFramework>net8.0</TargetFramework> but some MS packages are still only 7.0 vintage

  • Microsoft.AspNetCore.Components.Web
  • Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore
  • Microsoft.AspNetCore.Identity.EntityFrameworkCore
  • Microsoft.AspNetCore.Identity.UI
  • Microsoft.Extensions.Hosting
  • Microsoft.Extensions.Logging.Console

please update such projects to use at least 8.0.0 (GA LTS) releases. Thanks.

@ErikEJ
Copy link
Contributor

ErikEJ commented Jan 5, 2024

You could do a PR?

@DickBaker
Copy link
Contributor Author

DickBaker commented Jan 18, 2024

long and tedious PR in progress, especially bowing to analyzer guidelines to eliminate/reduce all the Warning/Message noise. FYI I found I needed to peg the "What's new in X.0" to that version [and not latest LTS v8] otherwise the analyzers gallup away with C# semantics that don't belong to their original era. Anyway I suspect I will inevitably conflict with someone's sacred cow.

@DickBaker
Copy link
Contributor Author

DickBaker commented Jan 19, 2024

I have now proposed PR4624, so get your red pens out

@ajcvickers ajcvickers added this to the Backlog milestone Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants