You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When running dotnet-script init in a directory that already has a launch.json file with other configurations, I found it a bit surprising that it totally overwrote what I had there:
$ dotnet-script init
Creating VS Code launch configuration file
...'/home/afk/temp/.vscode/launch.json' already exists' [Skipping]
...Use global tool launch config [Updated]
<snip>
I had experience with the tool running as non-global where it used [Updated] to mean modified and not overwritten.
_scriptConsole.WriteHighlighted($"...Fixed path to dotnet-script: '{dotnetScriptPath}' [Updated]");
So maybe changing the wording to something like
Creating VS Code launch configuration file
...'/home/afk/temp/.vscode/launch.json' already exists' [Skipping]
-...Use global tool launch config [Updated]+...Use global tool launch config [File Overwritten]
One other related small suggestion: maybe only highlight messages like [Updated] instead of [Skipping]. Highlighting the skipping messages (which don't feel important) trains me to ignore the highlights.
So instead of:
It would print something like:
I'm happy to make a PR, but the changes are very small and might take more effort to review rather than implement.
Thoughts?
The text was updated successfully, but these errors were encountered:
Just a small suggestion.
When running
dotnet-script init
in a directory that already has alaunch.json
file with other configurations, I found it a bit surprising that it totally overwrote what I had there:I had experience with the tool running as non-global where it used
[Updated]
to mean modified and not overwritten.dotnet-script/src/Dotnet.Script.Core/Scaffolder.cs
Line 183 in be49954
So maybe changing the wording to something like
One other related small suggestion: maybe only highlight messages like
[Updated]
instead of[Skipping]
. Highlighting the skipping messages (which don't feel important) trains me to ignore the highlights.So instead of:
It would print something like:
I'm happy to make a PR, but the changes are very small and might take more effort to review rather than implement.
Thoughts?
The text was updated successfully, but these errors were encountered: