Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WinUI] [3.1.0-beta.1] introduces null IDevice(s) to device lists #828

Closed
axa88 opened this issue Mar 20, 2024 · 9 comments · Fixed by #848
Closed

[WinUI] [3.1.0-beta.1] introduces null IDevice(s) to device lists #828

axa88 opened this issue Mar 20, 2024 · 9 comments · Fixed by #848
Labels
os:Windows regression

Comments

@axa88
Copy link

axa88 commented Mar 20, 2024 •
edited

Not observed in released v3.0x this beta introduces null IDevice to device collections.
This is most easily observed when scanning for devices and receiving null items in the IAdapter.DiscoveredDevices ReadOnlyList

Earlier testing indicated if devices are already Bonded/Connected the corresponding listing will also have null devices, I assume these share a common IDevice source

Expected behavior

Null Devices not in listing as in earlier release

Actual behavior

Null Devices in listing

image

Configuration

Version of the Plugin: e.g. 3.1 beta 1

Platform:
image

Device:

Device name	Portable
Processor	Intel(R) Core(TM) i5-8250U CPU @ 1.60GHz   1.80 GHz
Device ID	2F7EBCF5-2024-4778-9E85-988D5FD862D6
System type	64-bit operating system, x64-based processor

Intel Dual Band Wireless-AC 8265, Wi-Fi 2x2 802.11ac + **Bluetooth 4.1**, M.2 card
@smsissuechecker
Copy link

Hi @axa88,

I'm the friendly issue checker.
It seems like (25.00 %) you haven't used our issue template 😢 I think it is very frustrating for the repository owners, if you ignore them.

If you think it's fine to make an exception, just ignore this message.
But if you think it was a mistake to delete the template, please close the issue and create a new one.

Thanks!

@axa88 axa88 mentioned this issue Mar 20, 2024
Merged
This was referenced May 7, 2024
Merged
Closed
@janusw
Copy link
Member

janusw commented May 8, 2024

Since this is a regression of 3.1.x wrt 3.0.x, I think it should be fixed before the final 3.1.0 release.

Looking through the git history between 3.0.0 and 3.1.0-beta.1, one commit that makes significant changes to Adapter.AdvertisementReceived is 4fca5e3. Could this be the culprit here, @AskBojesen?

@AskBojesen
Copy link
Contributor

Ok - I will look into this now

@AskBojesen
Copy link
Contributor

AskBojesen commented May 8, 2024 •
edited

Nice finding @axa88 and nice spotted @janusw!
It was a commit in October, when I were a newbie in this plugin.
I have now fixed it in PR: #848

@AskBojesen AskBojesen mentioned this issue May 8, 2024
Merged
@axa88
Copy link
Author

axa88 commented May 9, 2024

Nice finding @axa88 and nice spotted @janusw!

if you liked that, i think i'll soon have more... 😃

@AskBojesen
Copy link
Contributor

Nice finding @axa88 and nice spotted @janusw!

if you liked that, i think i'll soon have more... 😃

Great!, I have time these coming days for that. Let us stick to bugfixes - no new features

janusw added a commit that referenced this issue May 11, 2024
@janusw
Merge pull request #848 from AskBojesen/828_null_in_devicelist_windows
18d5e3f 
Windows: Fixed null entries in DiscoveredDevices  #828
@axa88
Copy link
Author

axa88 commented May 11, 2024 •
edited

Great!, I have time these coming days for that. Let us stick to bugfixes - no new features

@AskBojesen
fwiw
#850

@AskBojesen
Copy link
Contributor

@janusw: Suggest to close this issue - since PR #848 is merged

@janusw
Copy link
Member

janusw commented May 13, 2024

@janusw: Suggest to close this issue - since PR #848 is merged

It's closed already! 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
os:Windows regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Windows: Fixed null entries in DiscoveredDevices #828 AskBojesen/dotnet-bluetooth-le
4 participants
@janusw @axa88 @smsissuechecker @AskBojesen