Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Publish new release with working version for old sdks #2144

Open
jyeros opened this issue Aug 15, 2023 · 3 comments
Open

Publish new release with working version for old sdks #2144

jyeros opened this issue Aug 15, 2023 · 3 comments

Comments

@jyeros
Copy link

jyeros commented Aug 15, 2023

The releases with sdks version 2 and 3.0 are not working because the myget source specified in the nuget.Config is not available anymore as mentioned in #1575.

It would be nice if you can publish a patch for those sdks with working versions, so it is possible to test them.

@jyeros
Copy link
Author

jyeros commented Aug 15, 2023

The changes implemented in this branch https://github.com/jyeros/eShopOnContainers/tree/3.0.0-without-myget are working without the myget source for SDK 3.0. See the Diff.

Similar on https://github.com/jyeros/eShopOnContainers/tree/2.0.8-without-myget

@jamesmontemagno
Copy link
Contributor

This looks pretty good, are you able to send down a PR?

@jyeros
Copy link
Author

jyeros commented Aug 23, 2023

This looks pretty good, are you able to send down a PR?

The base of the PRs should be tags 2.0.8 and 3.0.0. The problem is that I don't know how to open a PR having a tag as the base. I tried to use a branch, but I didn't see a branch in the commit where the tags are.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants