Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing EnvironmentAjaxAction by EnvironmentResource #28578

Open
jdotcms opened this issue May 15, 2024 · 3 comments · May be fixed by #28637
Open

Replacing EnvironmentAjaxAction by EnvironmentResource #28578

jdotcms opened this issue May 15, 2024 · 3 comments · May be fixed by #28637

Comments

@jdotcms
Copy link
Contributor

jdotcms commented May 15, 2024

Parent Issue

No response

User Story

As an user, I want to be able to create an PP env by using rest

Acceptance Criteria

UI uses the new endpoint to create a PP env

Proposed Objective

Core Features

Proposed Priority

Priority 3 - Average

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

Postman test for create env

Sub-Tasks & Estimates

No response

@wezell
Copy link
Contributor

wezell commented May 15, 2024

When adding the "allowed" roles permissions, the api now takes only RoleIds which can be hard to deal with. What we need to allow on the end point is to be able to pass a List which can be made up of roleIds, roleKeys, userIds and/or user emails, in that order. We should try to resolve what is passed in as we iterate over the list of strings when building the permissions for the env

@jearley-captech
Copy link

That would be fantastic to allow the API to take userId/email, role names as well (and let the system resolve these internally). That would really make it easy for setting up endpoints.

@jdotcms jdotcms self-assigned this May 15, 2024
@jdotcms
Copy link
Contributor Author

jdotcms commented May 15, 2024

Noted, working on it

jdotcms added a commit that referenced this issue May 23, 2024
@jdotcms jdotcms linked a pull request May 23, 2024 that will close this issue
jdotcms added a commit that referenced this issue May 24, 2024
jdotcms added a commit that referenced this issue May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

4 participants