Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running Experiment Cache is not working right #28514

Closed
freddyDOTCMS opened this issue May 9, 2024 · 3 comments
Closed

Running Experiment Cache is not working right #28514

freddyDOTCMS opened this issue May 9, 2024 · 3 comments

Comments

@freddyDOTCMS
Copy link
Contributor

Parent Issue

No response

Problem Statement

Right now when we start/stop an Experiment we are doing the follow:

public List<Experiment> cacheRunningExperiments() throws DotDataException {
final List<Experiment> experiments = FactoryLocator
.getExperimentsFactory()
.list(ExperimentFilter.builder().statuses(set(Status.RUNNING)).build());
experimentsCache.putList(ExperimentsCache.CACHED_EXPERIMENTS_KEY, experiments);
return experiments;

So we get a new Running Experiment list and put it on the cache, but the put cache operation is not cluster aware the only operation that is cluster aware on the cache context is remove so we need to just remove the Running Experiment list from cache and let it be populated again later when it is needed

Steps to Reproduce

  1. Run dotCMS on a Cluster environment.
  2. Create and Start and Experiment with a traffic load of 100%.
  3. Open a new incognito tab and visit any page, check if the isUserIncluded Endpoint hit and you are going to see that the just started Experiment was included on the Running Experiments check.
  4. Create a new Experiment with a traffic load of 100%. and start it
    1. Open a new incognito tab and visit any page, check if the isUserIncluded Endpoint hit and you are going to see that you were included just in the first Experiment, you should be included in both Experiment

Acceptance Criteria

The second time you should be included on the two Experiment all the time.

dotCMS Version

latest version in master

Proposed Objective

Core Features

Proposed Priority

Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response

@freddyDOTCMS
Copy link
Contributor Author

PR: #28540

@dsilvam
Copy link
Contributor

dsilvam commented May 15, 2024

Passing Internal QA: Unable to reproduce this behavior again.

@dsilvam dsilvam added QA : Passed Internal LTS : Next Ticket that will be added to LTS labels May 15, 2024
@josemejias11
Copy link

Approved: Tested on trunk_4c68b8f, Docker, macOS 13.0, FF v124.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants