Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Contentlet: Workflow Action Endpoint does not return the contentlet metadata #28338

Closed
Tracked by #25445
rjvelazco opened this issue Apr 23, 2024 · 0 comments · Fixed by #28369
Closed
Tracked by #25445

Edit Contentlet: Workflow Action Endpoint does not return the contentlet metadata #28338

rjvelazco opened this issue Apr 23, 2024 · 0 comments · Fixed by #28369

Comments

@rjvelazco
Copy link
Contributor

rjvelazco commented Apr 23, 2024

Parent Issue

#25445

Task

We must retrieve the binary field metadata when executing a workflow action.

  • Endpoint: /api/v1/workflow/actions/${workflowActionId}/fire?inode=${contentletInode}&indexPolicy=WAIT_FOR

Current Response

{
    "AUTO_ASSIGN_WORKFLOW": false,
    "__icon__": "jpgIcon",
    "archived": false,
    "baseType": "FILEASSET",
    "contentType": "Image",
    "underlyingFileName": "services-2.jpg",
    "url": "/images/pages/12345.jpg",
    "width": 844,
    "working": true
     ...Contentlet
}

Proposed Objective

Core Features

Proposed Priority

Priority 3 - Average

Acceptance Criteria

The Workflow Action endpoint should retrieve both the binary field metadata in the contentlet information. Our current response is a contentlet. We only need to attach the metadata as we do in the Contentlet API.

Desire Response

{
    "AUTO_ASSIGN_WORKFLOW": false,
    "__icon__": "jpgIcon",
    "archived": false,
    "baseType": "FILEASSET",
    "contentType": "Image",
    "underlyingFileName": "services-2.jpg",
    "url": "/images/pages/12345.jpg",
    "width": 844,
    "working": true
     "Metadata": {
          ...binaryMetadata
     },
     ...Contentlet
}

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response

This was referenced Apr 23, 2024
jdotcms added a commit that referenced this issue Apr 26, 2024
@jdotcms jdotcms self-assigned this Apr 26, 2024
jdotcms added a commit that referenced this issue Apr 30, 2024
jdotcms added a commit that referenced this issue May 1, 2024
github-merge-queue bot pushed a commit that referenced this issue May 10, 2024
Currently the contentlets on the WF rest API are not being hydrated, so
some properties are not part of the json result
The simple change will add the missing properties
@rjvelazco rjvelazco self-assigned this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Internal QA
Development

Successfully merging a pull request may close this issue.

2 participants