Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit Page V2: Edit Content Compare versions #27919

Closed
Tracked by #27546
zJaaal opened this issue Mar 8, 2024 · 3 comments · Fixed by #28311
Closed
Tracked by #27546

Edit Page V2: Edit Content Compare versions #27919

zJaaal opened this issue Mar 8, 2024 · 3 comments · Fixed by #28311
Assignees
@zJaaal @KevinDavilaDotCMS
Labels
OKR : User Experience Owned by Jason Priority : 3 Average QA : Approved Release : 24.05.13 Bug Fixing Team : Lunik Type : New Functionality

Comments

@zJaaal
Copy link
Contributor

zJaaal commented Mar 8, 2024

Parent Issue

#27546

User Story

As a user, I want to be able to compare versions from the edit content in edit ema, so I can decide which version I want to bring back.

Acceptance Criteria

  • Compare button in History Tab should work as the old edit page

How it should work

Screen.Recording.2024-03-08.at.4.18.53.PM.mov

Proposed Objective

User Experience

Proposed Priority

Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

  • Compare button should trigger an ng-event that should open an Angular Component
  • This Angular Component already exists.

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response
@zJaaal zJaaal mentioned this issue Mar 8, 2024
Open
@KevinDavilaDotCMS KevinDavilaDotCMS self-assigned this Apr 3, 2024
@KevinDavilaDotCMS
Copy link
Contributor

This ticket is on stand-by as it depends on the implementation of this ticket: #27549

@KevinDavilaDotCMS KevinDavilaDotCMS linked a pull request Apr 22, 2024 that will close this issue
chore(edit-page-2): implement compare versions #28311
Merged
@zJaaal zJaaal self-assigned this May 1, 2024
@zJaaal
Copy link
Contributor Author

zJaaal commented May 1, 2024 •
edited

IQA Failed IQA Passed

It works as expected for contentlets inside the editor

Tested on: [dotcms/dotcms:trunk]

Screenshot

Screen.Recording.2024-05-01.at.1.10.42.PM.mov

But when we try to bring back content for the Page, it looks like is returning an old version of the page, could be a race condition.

Update: After discussing this issue with the team, we decided to take care of this in another Issue

Screen.Recording.2024-05-01.at.1.09.29.PM.mov

@josemejias11
Copy link

Approved: Tested on trunk_318564e, Docker, macOS 13.0, FF v124.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zJaaal zJaaal

@KevinDavilaDotCMS KevinDavilaDotCMS

Labels
OKR : User Experience Owned by Jason Priority : 3 Average QA : Approved Release : 24.05.13 Bug Fixing Team : Lunik Type : New Functionality
Projects
dotCMS - Product Planning
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(edit-page-2): implement compare versions dotCMS/core
3 participants
@zJaaal @josemejias11 @KevinDavilaDotCMS