Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command line flag to set browser binary #117

Open
o0101 opened this issue Mar 17, 2022 · 6 comments
Open

Add command line flag to set browser binary #117

o0101 opened this issue Mar 17, 2022 · 6 comments

Comments

@o0101
Copy link
Collaborator

o0101 commented Mar 17, 2022

This could help people use Brave, and work on issues that seem to involve not finding the browser.

@levitabris
Copy link

Vivaldi user here. I have managed to let diskernet launch Vivaldi by adding export CHROME_PATH="/Applications/Vivaldi.app/Contents/MacOS/Vivaldi" to .profile. The only issue is diskernet still observes the default Chrome settings directory.

Terminal:

Args usage: <server_port> <save|serve> <chrome_port> <library_path>
Running in node...
Importing dependencies...
Attempting to shut running chrome...
There was no running chrome.
Removing 22120's existing temporary browser cache if it exists...
Launching library server...
Library server started.
Waiting 1 second...
{"server_up":{"upAt":"2022-03-23T09:06:40.140Z","port":22120}}
Launching chrome...
Chrome started.
Waiting 1 second...
Launching archivist and connecting to browser...
Observing /Users/XXXX/Library/Application Support/Google/Chrome/Default
System ready.

@ylluminarious
Copy link

@crisdosyago @levitabris What steps do you think might be necessary for an SSB such as Epichrome? Epichrome uses Brave, but it places each browser profile into a unique directory under ~/Library/Application Support/Epichrome/Apps. It runs a script that launches Brave with the appropriate launch flags, similar to this project.

Do you think it's possible to merge the functionality of this project with an Epichrome browser, and if so, what do you think would be the best way to do it? What snags should I be aware of that might conflict between the two?

@worldofgeese
Copy link

I'd love a flag to get Diskernet working with Edge

@o0101
Copy link
Collaborator Author

o0101 commented Sep 24, 2022

Oh thank you for that @levitabris, @ylluminarious and @worldofgeese! :)

@nobicycle
Copy link

nobicycle commented Jan 23, 2023

Vivaldi appears to work

$ CHROME_PATH="/usr/bin/vivaldi-stable" diskernet 
/usr/lib/node_modules/diskernet/build /usr/lib/node_modules/diskernet/build/diskernet.cjs
{ APP_ROOT: '/usr/lib/node_modules/diskernet/build' }
{ root: '/usr/lib/node_modules/diskernet/build' }
Args usage: <server_port> <save|serve> <chrome_port> <library_path>
Running in node...
Importing dependencies...
Removing 22120's existing temporary browser cache if it exists...
Launching library server...
No certs found so will use insecure no SSL.
Library server started.
Waiting 1 second...
{"server_up":{"upAt":"2023-01-23T03:14:11.190Z","port":22120}}
Launching chrome...
  LH:ChromeLauncher No debugging port found on port 9222, launching a new Chrome. +0ms
  LH:ChromeLauncher:verbose created /tmp/lighthouse.37aPsxZ +101ms
  LH:ChromeLauncher:verbose Launching with command:
  LH:ChromeLauncher:verbose "/usr/bin/vivaldi-stable" --remote-debugging-port=9222 --disk-cache-dir=/home/user/.config/dosyago/DiskerNet/22120-arc/temp-browser-cache0.6957129115711098 --aggressive-cache-discard http://localhost:22120 +1ms
  LH:ChromeLauncher:verbose Chrome running with pid 26659 on port 9222. +15ms
  LH:ChromeLauncher Waiting for browser. +0ms
  LH:ChromeLauncher Waiting for browser... +0ms
  LH:ChromeLauncher Waiting for browser..... +502ms
  LH:ChromeLauncher Waiting for browser....... +502ms
  LH:ChromeLauncher Waiting for browser.......✓ +2ms
Chrome started.
Waiting 1 second...
Launching archivist and connecting to browser...
{ Mode: 'save' }
Not observing
System ready.

but http://localhost:22120 displays nothing ...

@yair-mantis
Copy link

attempt with directing to edge browser on windows
$env:CHROME_PATH="C:\Program Files (x86)\Microsoft\Edge\Application\msedge.exe"
it does launch localhost:22120 but errors out on any interaction.

PS C:\Users\user> diskernet.cmd
Index can use up to: 52363MB RAM
C:\Users\user\AppData\Roaming\npm\node_modules\diskernet\build C:\Users\user\AppData\Roaming\npm\node_modules\diskernet\build\diskernet.cjs
{
  APP_ROOT: 'C:\\Users\\user\\AppData\\Roaming\\npm\\node_modules\\diskernet\\build'
}
{
  root: 'C:\\Users\\user\\AppData\\Roaming\\npm\\node_modules\\diskernet\\build'
}
Args usage: <server_port> <save|serve> <chrome_port> <library_path>
Running in node...
Importing dependencies...
Removing 22120's existing temporary browser cache if it exists...
Launching library server...
No certs found so will use insecure no SSL.
Library server started.
Waiting 1 second...
{"server_up":{"upAt":"2024-04-07T09:34:23.960Z","port":22120}}
Launching chrome...
  LH:ChromeLauncher No debugging port found on port 9222, launching a new Chrome. +0ms
  LH:ChromeLauncher:verbose created C:\Users\user\AppData\Local\Temp\lighthouse.43323218 +3ms
  LH:ChromeLauncher:verbose Launching with command:
  LH:ChromeLauncher:verbose "C:\Program Files (x86)\Microsoft\Edge\Application\msedge.exe" --remote-debugging-port=9222 --disk-cache-dir=C:\Users\user\.config\dosyago\DiskerNet\22120-arc\temp-browser-cache0.6151509584190638 --aggressive-cache-discard http://localhost:22120 +0ms
  LH:ChromeLauncher:verbose Chrome running with pid 84228 on port 9222. +7ms
  LH:ChromeLauncher Waiting for browser. +0ms
  LH:ChromeLauncher Waiting for browser... +1ms
...
  LH:ChromeLauncher Waiting for browser..................... +501ms
  LH:ChromeLauncher:error connect ECONNREFUSED 127.0.0.1:9222 +1ms
  LH:ChromeLauncher:error Logging contents of C:\Users\user\AppData\Local\Temp\lighthouse.43323218/chrome-err.log +0ms
  LH:ChromeLauncher:error  +0ms
Could not launch chrome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants