Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak(monokai): make regions in org blocks visible #815

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Walheimat
Copy link

Adds override for face org-block to avoid a region within the block begin indistinguishable from the block's background. Uses face base2 for org-block{-background,-begin-line]}.

Theme doom-theme-monokai-pro was not included since it doesn't have this problem.

  • themes/doom-monokai-classic-theme.el
  • themes/doom-monokai-machine-theme.el
  • themes/doom-monokai-octagon-theme.el
  • themes/doom-monokai-ristretto-theme.el
  • themes/doom-monokai-spectrum-theme.el

Fix: #762

  • I searched the issue tracker and this hasn't been PRed before.
  • My changes are not on the do-not-PR list for this project.
  • My commits conform to the git conventions.
  • My changes are visual; I've included before and after screenshots.
  • Any relevant issues or PRs have been linked to.
  • This a draft PR; I need more time to finish it.

Screenshot

Using doom-monokai-machine as an example.

Before

machine-before

After

machine-after

Adds override for face `org-block` to avoid a region within the block begin
indistinguishable from the block's background. Uses face `base2` for
`org-block{-background,-begin-line]}`.

Theme `doom-theme-monokai-pro` was not included since it doesn't have this
problem.

* themes/doom-monokai-classic-theme.el
* themes/doom-monokai-machine-theme.el
* themes/doom-monokai-octagon-theme.el
* themes/doom-monokai-ristretto-theme.el
* themes/doom-monokai-spectrum-theme.el

Fix: doomemacs#762
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No contrast in org mode code block with doom-monokai-octagon when highlighting code.
1 participant