Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No contrast in org mode code block with doom-monokai-octagon when highlighting code. #762

Open
cddesja opened this issue Nov 18, 2022 · 1 comment · May be fixed by #815
Open

No contrast in org mode code block with doom-monokai-octagon when highlighting code. #762

cddesja opened this issue Nov 18, 2022 · 1 comment · May be fixed by #815
Labels
is:feature Adds or requests new features, or extends existing ones needs-triage Issue hasn't been assessed yet

Comments

@cddesja
Copy link

cddesja commented Nov 18, 2022

Describe your request

For the doom-monokai-octagon, which is wonderful by the way, when I select text in an org-mode code block, the highlighted text is the same color as the background so there's no visual indication of what text is being selected.

I believe the background color of the org code block needs to changed or the selected text color for the theme.

If you do not want to fulfill request, could you let me know how I can do this locally?

I can upload a screencast if it would help.

Briefly explain its use-case

  1. Install doom-themes
  2. Select the doom-monokai-octagon theme
  3. Create a code block with the code in it.
  4. Highlight the code in the block and notice that the background color is the same color as the highlight color.
@cddesja cddesja added is:feature Adds or requests new features, or extends existing ones needs-triage Issue hasn't been assessed yet labels Nov 18, 2022
@Walheimat
Copy link

The doom-monokai-* themes are really nice but this is a minor annoyance.

I'm not sure if this a valid way for all the themes, but setting the following (in the face overrides) could be one way to solve this.

((org-block &override) :background base2)
((org-block-background &override) :background base2)
((org-block-begin-line &override) :background base2)

This is what is done in many other themes.

Walheimat added a commit to Walheimat/doom-themes that referenced this issue Dec 29, 2023
@Walheimat
tweak(monokai): avoid invisible regions in org blocks
afc6173 
Adds override for face `org-block` to avoid a region within the block begin
indistinguishable from the block's background. Uses face `base2` for
`org-block{-background,-begin-line]}`.

Theme `doom-theme-monokai-pro` was not included since it doesn't have this
problem.

Closes doomemacs#762.
Walheimat added a commit to Walheimat/doom-themes that referenced this issue Dec 29, 2023
@Walheimat
tweak(monokai): make regions in org blocks visible
8fb76cb 
Adds override for face `org-block` to avoid a region within the block begin
indistinguishable from the block's background. Uses face `base2` for
`org-block{-background,-begin-line]}`.

Theme `doom-theme-monokai-pro` was not included since it doesn't have this
problem.

* themes/doom-monokai-classic-theme.el
* themes/doom-monokai-machine-theme.el
* themes/doom-monokai-octagon-theme.el
* themes/doom-monokai-ristretto-theme.el
* themes/doom-monokai-spectrum-theme.el

Fix: doomemacs#762
@Walheimat Walheimat linked a pull request Dec 29, 2023 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
is:feature Adds or requests new features, or extends existing ones needs-triage Issue hasn't been assessed yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tweak(monokai): make regions in org blocks visible Walheimat/doom-themes
2 participants
@cddesja @Walheimat