Skip to content
This repository has been archived by the owner on Apr 16, 2024. It is now read-only.

[BUG][next] luacheck required? #363

Open
baurmatt opened this issue Jul 18, 2022 · 3 comments
Open

[BUG][next] luacheck required? #363

baurmatt opened this issue Jul 18, 2022 · 3 comments
Labels
scope: bug Something isn't working

Comments

@baurmatt
Copy link

Current Behavior:

[null-ls] [ERROR 16:17:39] ...t/null-ls.nvim/lua/null-ls/helpers/generator_factory.lua:180: command luacheck is not executable (make sure it's installed and on your $PATH)

Expected Behavior:

No error pops up :) The README doesn't mention luacheck as a dependency :)

Steps To Reproduce:

Logs

Check Health Output
Doom Report Output

Anything else:

@baurmatt baurmatt added the scope: bug Something isn't working label Jul 18, 2022
@connorgmeehan
Copy link
Collaborator

connorgmeehan commented Jul 18, 2022

Null-ls is a bit of a challenge because there's no auto-installer for it so it relies on system dependencies so if you want it to work you'll have to install it luarocks install luacheck. What's a good way to make it clearer to the user that it needs to be installed? I could at a note in the dependencies section of the readme.

Also thanks for these bugreports :) They don't seem to hard so I'll sort them out soon hopefully.

@baurmatt
Copy link
Author

Ah, so this error popups up because lsp is now enabled by default for all languages unlike in the current stable where lsp is disable for lua by default? Does this affect other languages as well?

Can we disable it by default for lua? ;)

@connorgmeehan
Copy link
Collaborator

Ok now that https://github.com/williamboman/mason.nvim has been released this is something we'll implement for the next release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants