Attempt to invoke interface method 'IInAppBillingService.getPurchases()' on a null object reference

[eminsr]

Version of react-native-iap

"react-native-iap": "^2.3.17"

Platforms you faced the error (IOS or Android or both?)

Android

Expected behavior

it should check if mService is null before calling getPurchases()

Actual behavior

It doesn't check if mService is null and throws this error
Attempt to invoke interface method 'android.os.Bundle com.android.vending.billing.IInAppBillingService.getPurchases(int, java.lang.String, java.lang.String, java.lang.String)' on a null object reference

Tested environment (Emulator? Real Device?)

Real Device Android 6.0

Steps to reproduce the behavior

Just call RNIap.getAvailablePurchases() after initConnection(),

const result = await RNIap.initConnection();
const purchases = await RNIap.getAvailablePurchases();

I temporarily fix it by setting a timeout for getAvailablePurchases()

[hyochan]

Can you show us in which line of code in Android it occurs? If it is wrapped with ensureConnection it should be fine because it is checking whether mService is null. Where do you think the problem is occurring?

Also, try below too.

const result = await RNIap.initConnection();
if (result) {
  const purchases = await RNIap.getAvailablePurchases();
}

[eminsr]

I tried a couple of times, adding if statement seems like fixed it. I didn't understand why though it always returns the same thing. Anyway, thanks.

[eminsr]

I spoke too soon it still causing a crash.

I think there is a time gap between onBillingSetupFinished and onServiceConnected. initConnection() resolves on onBillingSetupFinished but until the service is connected mService is null.

To fix it in RNIapModule I simply catch the NullPointerException and reject the promise than when getAvailablePurchases() is rejected, in the catch I started another getAvailablePurchases() request.

If we can find a solution to resolve initConnection() after the mService is not null that would be great. But I can't think any way that doesn't involve a listener for mService.

[hyochan]

@eminsr Could you give a PR on what you've tried first? It might be helpful.

[hyochan]

Just merged your PR lets see what we can do. Also @LinusU can you give some help with this issue? I remember you've updated some codes here.

[LinusU]

@eminsr could we modify ensureConnection to wait for mService as well? That should work, right 🤔

[eminsr]

@LinusU yea that should fix the issue.

[hyochan]

@LinusU @eminsr Could someone give PR for this?

[eminsr]

Maybe we can add a while loop to initConnection() but this doesn't seem like the right way to do it.

  @ReactMethod
  public void initConnection(final Promise promise) {
    ensureConnection(promise, new Runnable() {
      @Override
      public void run() {
        while(mService == null){
          Thread.sleep(250);
        }
        promise.resolve(true);
      }
    });
  }

[hyochan]

I will close this since this is related #315