Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve dedup doc : default params #1145

Open
Makio64 opened this issue Oct 29, 2023 · 1 comment
Open

improve dedup doc : default params #1145

Makio64 opened this issue Oct 29, 2023 · 1 comment
Labels
documentation feature New enhancement or request

Comments

@Makio64
Copy link
Contributor

Makio64 commented Oct 29, 2023

Is your feature request related to a problem? Please describe.
Improve the documentation of dedup function to specify the property dedup by default :

		PropertyType.ACCESSOR,
		PropertyType.MESH,
		PropertyType.TEXTURE,
		PropertyType.MATERIAL,
		PropertyType.SKIN,

Describe alternatives you've considered
Alternative : also add it to DedupOptions

Additional context
While reading the documentation page of dedup, I wasnt sure and went to the source code to double check, I think it can be easily avoid for futur users.

@Makio64 Makio64 added the feature New enhancement or request label Oct 29, 2023
@donmccurdy donmccurdy added this to the 🗄️ Backlog milestone Oct 29, 2023
@donmccurdy
Copy link
Owner

I think greendoc (https://github.com/donmccurdy/greendoc) does not yet support documentation of default parameters, so the feature would need to be added there first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation feature New enhancement or request
Projects
None yet
Development

No branches or pull requests

2 participants