{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":76605693,"defaultBranch":"master","name":"frr","ownerLogin":"donaldsharp","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2016-12-15T23:57:18.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/10601296?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1717171779.0","currentOid":""},"activityList":{"items":[{"before":null,"after":"fe4e1841c5d58b96942d43ccfbf6ff32962d3ac7","ref":"refs/heads/linklist_discouragement","pushedAt":"2024-05-31T16:09:39.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"donaldsharp","name":"Donald Sharp","path":"/donaldsharp","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10601296?s=80&v=4"},"commit":{"message":"lib: Discourage usage of deprecated data structures\n\nPut some verbiage in place to warn people that we\nare actively discouraging new development that uses\nan older data structure.\n\nSigned-off-by: Donald Sharp ","shortMessageHtmlLink":"lib: Discourage usage of deprecated data structures"}},{"before":null,"after":"5ef144ce6d03d2dc2d36cf7d0e6ef6ce8ba6d2dc","ref":"refs/heads/mroute_error","pushedAt":"2024-05-31T15:30:30.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"donaldsharp","name":"Donald Sharp","path":"/donaldsharp","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10601296?s=80&v=4"},"commit":{"message":"pimd: Give a clearer warning when the kernel is not compiled right\n\nWhen the kernel is not compiled with mroute vrf's enabled it will\nfail the call to initialize the vrf. As such let's recognize this\nspecific error code and output a specific warning to the operator\nto help them figure this problem out.\n\nSigned-off-by: Donald Sharp ","shortMessageHtmlLink":"pimd: Give a clearer warning when the kernel is not compiled right"}},{"before":null,"after":"826f2510e67711045e52cf4b5e3ddef514ed556e","ref":"refs/heads/ospfv3_read_after","pushedAt":"2024-05-30T12:02:58.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"donaldsharp","name":"Donald Sharp","path":"/donaldsharp","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10601296?s=80&v=4"},"commit":{"message":"ospf6d: Prevent heap-buffer-overflow with unknown type\n\nWhen parsing a osf6 grace lsa field and we receive an\nunknown tlv type, ospf6d was not incrementing the pointer\nto get beyond the tlv. Leaving a situation where ospf6d\nwould parse the packet incorrectly.\n\nSigned-off-by: Iggy Frankovic ","shortMessageHtmlLink":"ospf6d: Prevent heap-buffer-overflow with unknown type"}},{"before":null,"after":"f766686bce471e95764a94eebbf5e7a5da076a7f","ref":"refs/heads/seg6_topotest_fix","pushedAt":"2024-05-29T18:53:42.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"donaldsharp","name":"Donald Sharp","path":"/donaldsharp","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10601296?s=80&v=4"},"commit":{"message":"tests: Fix zebra_seg6_route\n\nLocally this test would occassionally fail for me\nbecause the connected route the sharp route being\ninstalled has not fully come up yet due to heavy\nload and start up slowness. Add a bit of code\nto look for the problem and make sure it doesn't\nhappen.\n\nSigned-off-by: Donald Sharp ","shortMessageHtmlLink":"tests: Fix zebra_seg6_route"}},{"before":"cfb538c668b2472c4eedd725155d9723797939da","after":"3ec469c2f316f61db5757985205058350e288418","ref":"refs/heads/memories_i_love_you","pushedAt":"2024-05-24T19:25:07.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"donaldsharp","name":"Donald Sharp","path":"/donaldsharp","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10601296?s=80&v=4"},"commit":{"message":"lib: Thread is being used and set at the same time\n\nThe call to set thread is being used and set at the\nsame time in various pthreads in the code. This\nshould not be happening. Let's fix it.\n\nSigned-off-by: Donald Sharp ","shortMessageHtmlLink":"lib: Thread is being used and set at the same time"}},{"before":null,"after":"cfb538c668b2472c4eedd725155d9723797939da","ref":"refs/heads/memories_i_love_you","pushedAt":"2024-05-23T12:25:46.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"donaldsharp","name":"Donald Sharp","path":"/donaldsharp","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10601296?s=80&v=4"},"commit":{"message":"zebra: Fix misaligned long long unsigned int\n\nError message:\n./multicast_pim_dr_nondr_test.test_pim_dr_nondr_with_ospf_topo2/r5/zebra.err:zebra/rt_netlink.c:1142:15: runtime error: load of misaligned address 0x7bb40000a064 for type 'long long unsigned int', which requires 8 byte alignment\n\nFix it.\n\nSigned-off-by: Donald Sharp ","shortMessageHtmlLink":"zebra: Fix misaligned long long unsigned int"}},{"before":null,"after":"d284e2229691baf3f1df0af1b184932d06828cdc","ref":"refs/heads/show_ip_route_summary","pushedAt":"2024-05-20T19:46:57.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"donaldsharp","name":"Donald Sharp","path":"/donaldsharp","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10601296?s=80&v=4"},"commit":{"message":"doc: Add missing `show ip route summ` command\n\nSigned-off-by: Donald Sharp ","shortMessageHtmlLink":"doc: Add missing show ip route summ command"}},{"before":"75b7746cc4e19fac93085dc3e20f6030039548b8","after":"089746af862cd41e0ba3a87a07277c4fe26cf593","ref":"refs/heads/frr-8.5.1_backport_backpressure","pushedAt":"2024-05-15T16:22:25.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"donaldsharp","name":"Donald Sharp","path":"/donaldsharp","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10601296?s=80&v=4"},"commit":{"message":"FIX BORKED UP backport","shortMessageHtmlLink":"FIX BORKED UP backport"}},{"before":"300ca692c72af7be00646f0dc16632417c3fd3f4","after":"73ad64a6f4b039ce482ad5c3b080e8c9bb02890f","ref":"refs/heads/agentx_update","pushedAt":"2024-05-10T14:37:52.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"donaldsharp","name":"Donald Sharp","path":"/donaldsharp","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10601296?s=80&v=4"},"commit":{"message":"*: Modify agentx to be allowed to be called\n\nIf you had a situation where an operator turned on\nospfd with snmp but not ospf6d and agentx was configured\nthen you get into a situation where ospf6d would complain\nthat the config for agentx did not exist. Let's modify\nthe code to allow this situation to happen.\n\nFixes: #15896\nSigned-off-by: Donald Sharp ","shortMessageHtmlLink":"*: Modify agentx to be allowed to be called"}},{"before":null,"after":"c7a3f82db580659321ff12faaf89abf8c780d3c9","ref":"refs/heads/8.5_parse_rtattrs","pushedAt":"2024-05-09T15:57:02.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"donaldsharp","name":"Donald Sharp","path":"/donaldsharp","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10601296?s=80&v=4"},"commit":{"message":"zebra: Ensure multipath encodes vxlan right for fpm usage\n\nThe fpm code path for the dplane_fpm_nl module was improperly\nencoding the multipath nexthop data for vxlan type routes.\nMove this into the embedded nexthop encoding where it belongs.\n\nThis change makes it so that the usage of `-M dplane_fpm_nl`\nis now producing the same netlink messages that `-M fpm`\nproduces when using vxlan based nexthops.\n\nSigned-off-by: Donald Sharp ","shortMessageHtmlLink":"zebra: Ensure multipath encodes vxlan right for fpm usage"}},{"before":"058b272c9a48d8ccb427fe49cafe5440ae24e8ab","after":"bd4fca132abd47d1ba08eca5e5193c431f095f7a","ref":"refs/heads/parse_attr_problems","pushedAt":"2024-05-09T15:52:58.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"donaldsharp","name":"Donald Sharp","path":"/donaldsharp","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10601296?s=80&v=4"},"commit":{"message":"zebra: Ensure multipath encodes vxlan right for fpm usage\n\nThe fpm code path for the dplane_fpm_nl module was improperly\nencoding the multipath nexthop data for vxlan type routes.\nMove this into the embedded nexthop encoding where it belongs.\n\nThis change makes it so that the usage of `-M dplane_fpm_nl`\nis now producing the same netlink messages that `-M fpm`\nproduces when using vxlan based nexthops.\n\nSigned-off-by: Donald Sharp ","shortMessageHtmlLink":"zebra: Ensure multipath encodes vxlan right for fpm usage"}},{"before":"88d3912844ed3340b0cab0c29595c2233f355444","after":"300ca692c72af7be00646f0dc16632417c3fd3f4","ref":"refs/heads/agentx_update","pushedAt":"2024-05-09T11:57:24.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"donaldsharp","name":"Donald Sharp","path":"/donaldsharp","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10601296?s=80&v=4"},"commit":{"message":"*: Modify agentx to be allowed to be called\n\nIf you had a situation where an operator turned on\nospfd with snmp but not ospf6d and agentx was configured\nthen you get into a situation where ospf6d would complain\nthat the config for agentx did not exist. Let's modify\nthe code to allow this situation to happen.\n\nFixes: #15896\nSigned-off-by: Donald Sharp ","shortMessageHtmlLink":"*: Modify agentx to be allowed to be called"}},{"before":null,"after":"88d3912844ed3340b0cab0c29595c2233f355444","ref":"refs/heads/agentx_update","pushedAt":"2024-05-09T11:49:19.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"donaldsharp","name":"Donald Sharp","path":"/donaldsharp","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10601296?s=80&v=4"},"commit":{"message":"*: Modify agentx to be allowed to be called\n\nIf you had a situation where an operator turned on\nospfd with snmp but not ospf6d and agentx was configured\nthen you get into a situation where ospf6d would complain\nthat the config for agentx did not exist. Let's modify\nthe code to allow this situation to happen.\n\nFixes: #15896\nSigned-off-by: Donald Sharp ","shortMessageHtmlLink":"*: Modify agentx to be allowed to be called"}},{"before":"e81eeeabecac3df5e80ee16046c52b5715c1a87c","after":"058b272c9a48d8ccb427fe49cafe5440ae24e8ab","ref":"refs/heads/parse_attr_problems","pushedAt":"2024-05-08T17:33:14.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"donaldsharp","name":"Donald Sharp","path":"/donaldsharp","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10601296?s=80&v=4"},"commit":{"message":"zebra: Ensure multipath encodes vxlan right for fpm usage\n\nThe fpm code path for the dplane_fpm_nl module was improperly\nencoding the multipath nexthop data for vxlan type routes.\nMove this into the embedded nexthop encoding where it belongs.\n\nThis change makes it so that the usage of `-M dplane_fpm_nl`\nis now producing the same netlink messages that `-M fpm`\nproduces when using vxlan based nexthops.\n\nSigned-off-by: Donald Sharp ","shortMessageHtmlLink":"zebra: Ensure multipath encodes vxlan right for fpm usage"}},{"before":"26595e316275768ca32f3788b2bce2eb16cfc62d","after":"e81eeeabecac3df5e80ee16046c52b5715c1a87c","ref":"refs/heads/parse_attr_problems","pushedAt":"2024-05-08T16:57:13.000Z","pushType":"push","commitsCount":101,"pusher":{"login":"donaldsharp","name":"Donald Sharp","path":"/donaldsharp","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10601296?s=80&v=4"},"commit":{"message":"zebra: Ensure multipath encodes vxlan right for fpm usage\n\nThe fpm code path for the dplane_fpm_nl module was improperly\nencoding the multipath nexthop data for vxlan type routes.\nMove this into the embedded nexthop encoding where it belongs.\n\nThis change makes it so that the usage of `-M dplane_fpm_nl`\nis now producing the same netlink messages that `-M fpm`\nproduces when using vxlan based nexthops.\n\nSigned-off-by: Donald Sharp ","shortMessageHtmlLink":"zebra: Ensure multipath encodes vxlan right for fpm usage"}},{"before":null,"after":"26595e316275768ca32f3788b2bce2eb16cfc62d","ref":"refs/heads/parse_attr_problems","pushedAt":"2024-04-30T18:55:29.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"donaldsharp","name":"Donald Sharp","path":"/donaldsharp","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10601296?s=80&v=4"},"commit":{"message":"zebra: Ensure proper decoding of netlink message\n\nAs part of the kernel netlink functionality, it is\npossible that a bit of nested attributes can be\npassed up. This attribute has a type value which\nis stored in the lower 8 bits and in the upper 8\nbits are a couple control flags that can be used.\nFRR can parse this data and then just throw away\nthe value unless we mask off the upper 8 bits.\nLet's ensure that it can be properly parsed.\n\nSigned-off-by: Donald Sharp ","shortMessageHtmlLink":"zebra: Ensure proper decoding of netlink message"}},{"before":null,"after":"3d2a8d8440b752245b2ec8bf507b29fb2f35ff7b","ref":"refs/heads/frr-8.5.4_backport_nhg_check","pushedAt":"2024-04-26T17:52:25.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"donaldsharp","name":"Donald Sharp","path":"/donaldsharp","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10601296?s=80&v=4"},"commit":{"message":"lib, zebra: Check for not being a blackhole route\n\nIn zebra_interface_nhg_reinstall zebra is checking that the\nnhg is a singleton and not a blackhole nhg. This was originally\ndone with checking that the nexthop is a NEXTHOP_TYPE_IFINDEX,\nNEXTHOP_TYPE_IPV4_IFINDEX and NEXTHOP_TYPE_IPV6_IFINDEX. This\nwas excluding NEXTHOP_TYPE_IPV4 and NEXTHOP_TYPE_IPV6. These\nwere both possible to be received and maintained from the upper\nlevel protocol for when a route is being recursively resolved.\nIf we have gotten to this point in zebra_interface_nhg_reinstall\nthe nexthop group has already been installed at least once\nand we *know* that it is actually a valid nexthop. What the\ntest is really trying to do is ensure that we are not reinstalling\na blackhole nexthop group( Which is not possible to even be\nhere by the way, but safety first! ). So let's change\nto test for that instead.\n\nSigned-off-by: Donald Sharp ","shortMessageHtmlLink":"lib, zebra: Check for not being a blackhole route"}},{"before":"9068066053517f29b9fe593a347ff85b618996f7","after":"0c4b7c1f1f359c1d7647fea34f62378af8b640a5","ref":"refs/heads/pim_crash_dnode","pushedAt":"2024-04-26T14:14:54.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"donaldsharp","name":"Donald Sharp","path":"/donaldsharp","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10601296?s=80&v=4"},"commit":{"message":"pimd: fix crash unconfiguring rp keepalive timer\n\npimd crashs while unconfigure of rp ka timer as we are trying to access\na yand dnode(suppress timer) which does not exist at the moment.\n\nUser just configured rp keepalive timer and not suppress timer,\nthe yang dnode would not be present. Instead of directly accessing\nyang_dnode_get_unit16, first check the yang node exist using\nthe xpath.\n\nTicket: #3874971\n\nTesting:\n\nBefore:\n------\ntor-11(config)# no ip pim rp keep-alive-timer 3000\nvtysh: error reading from pimd: Success (0)Warning: closing connection to pimd because of an I/O error!\n\nBroadcast message from root@tor-11 (somewhere) (Mon Apr 22 17:29:12 2024):\n\ncumulus-core: Running cl-support for core files \"pimd.25467.1713806952.core\"\n\nAfter:\n-----\ntor-11(config)# no ip pim rp keep-alive-timer 3000\ntor-11(config)#\n\nSigned-off-by: Donald Sharp \nSigned-off-by: Vijayalaxmi Basavaraj ","shortMessageHtmlLink":"pimd: fix crash unconfiguring rp keepalive timer"}},{"before":null,"after":"b4c64b3a39da0acb053a7d527aee9a5a3ab35133","ref":"refs/heads/sa_clang_15_some_problems","pushedAt":"2024-04-25T18:45:52.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"donaldsharp","name":"Donald Sharp","path":"/donaldsharp","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10601296?s=80&v=4"},"commit":{"message":"bgpd: Remove unused addition found in clang\n\nSigned-off-by: Donald Sharp ","shortMessageHtmlLink":"bgpd: Remove unused addition found in clang"}},{"before":null,"after":"62143963065d9841dae014aa8d565704f9670054","ref":"refs/heads/redistibute_doc_change","pushedAt":"2024-04-25T18:18:09.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"donaldsharp","name":"Donald Sharp","path":"/donaldsharp","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10601296?s=80&v=4"},"commit":{"message":"bgpd: Explain Better admin w/ redistribution a bit better.\n\nSigned-off-by: Donald Sharp ","shortMessageHtmlLink":"bgpd: Explain Better admin w/ redistribution a bit better."}},{"before":null,"after":"9068066053517f29b9fe593a347ff85b618996f7","ref":"refs/heads/pim_crash_dnode","pushedAt":"2024-04-25T18:08:36.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"donaldsharp","name":"Donald Sharp","path":"/donaldsharp","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10601296?s=80&v=4"},"commit":{"message":"pimd: fix crash unconfiguring rp keepalive timer\n\npimd crashs while unconfigure of rp ka timer as we are trying to access\na yand dnode(suppress timer) which does not exist at the moment.\n\nUser just configured rp keepalive timer and not suppress timer,\nthe yang dnode would not be present. Instead of directly accessing\nyang_dnode_get_unit16, first check the yang node exist using\nthe xpath.\n\nTicket: #3874971\n\nTesting:\n\nBefore:\n------\ntor-11(config)# no ip pim rp keep-alive-timer 3000\nvtysh: error reading from pimd: Success (0)Warning: closing connection to pimd because of an I/O error!\n\nBroadcast message from root@tor-11 (somewhere) (Mon Apr 22 17:29:12 2024):\n\ncumulus-core: Running cl-support for core files \"pimd.25467.1713806952.core\"\n\nAfter:\n-----\ntor-11(config)# no ip pim rp keep-alive-timer 3000\ntor-11(config)#\n\nSigned-off-by: Donald Sharp \nSigned-off-by: Vijayalaxmi Basavaraj ","shortMessageHtmlLink":"pimd: fix crash unconfiguring rp keepalive timer"}},{"before":null,"after":"007375cd3d24cecb2a98c115e910c92617320fec","ref":"refs/heads/frr-8.4.4_backport_wcmp","pushedAt":"2024-04-24T17:04:54.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"donaldsharp","name":"Donald Sharp","path":"/donaldsharp","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10601296?s=80&v=4"},"commit":{"message":"tests: Fixup bgp_link_bw_ip test to new behavior\n\nOld behavior was metric values between 1-100,\nnow we have metric values between 1-255.\n\nSigned-off-by: Donald Sharp ","shortMessageHtmlLink":"tests: Fixup bgp_link_bw_ip test to new behavior"}},{"before":null,"after":"0948a35db6ba177b6409bc91a0036b11e6f7ad0c","ref":"refs/heads/frr-8.5.1_backport_wcmp","pushedAt":"2024-04-24T16:58:17.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"donaldsharp","name":"Donald Sharp","path":"/donaldsharp","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10601296?s=80&v=4"},"commit":{"message":"tests: Fixup bgp_link_bw_ip test to new behavior\n\nOld behavior was metric values between 1-100,\nnow we have metric values between 1-255.\n\nSigned-off-by: Donald Sharp ","shortMessageHtmlLink":"tests: Fixup bgp_link_bw_ip test to new behavior"}},{"before":"ebe372ae6a13ae7bd5a8bef4b2da585900bce50c","after":"75b7746cc4e19fac93085dc3e20f6030039548b8","ref":"refs/heads/frr-8.5.1_backport_backpressure","pushedAt":"2024-04-22T17:51:53.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"donaldsharp","name":"Donald Sharp","path":"/donaldsharp","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10601296?s=80&v=4"},"commit":{"message":"zebra: Actually display I/O buffer sizes (part-2)\n\nAn extension of commit-8d8f12ba8e5cd11c189b8475b05539fa8415ccb9\n\nRemoving ifdef DEV_BUILD in stream_fifo_push as well to make the 'sh\nzebra client' display the current I/O fifo along with max fifo items.\n\nTICKET :#3390099\n\nSigned-off-by: Rajasekar Raja ","shortMessageHtmlLink":"zebra: Actually display I/O buffer sizes (part-2)"}},{"before":null,"after":"ebe372ae6a13ae7bd5a8bef4b2da585900bce50c","ref":"refs/heads/frr-8.5.1_backport_backpressure","pushedAt":"2024-04-22T15:58:55.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"donaldsharp","name":"Donald Sharp","path":"/donaldsharp","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10601296?s=80&v=4"},"commit":{"message":"zebra: backpressure - Fix Null ptr access (Coverity Issue)\n\nFix dereferencing NULL ptr making coverity happy.\n\nTicket :#3390099\n\nSigned-off-by: Rajasekar Raja ","shortMessageHtmlLink":"zebra: backpressure - Fix Null ptr access (Coverity Issue)"}},{"before":null,"after":"29c1ff446e581fc403d155fd1d00b7c944cba56a","ref":"refs/heads/blackhole_reinstall","pushedAt":"2024-04-22T14:46:26.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"donaldsharp","name":"Donald Sharp","path":"/donaldsharp","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10601296?s=80&v=4"},"commit":{"message":"lib, zebra: Check for not being a blackhole route\n\nIn zebra_interface_nhg_reinstall zebra is checking that the\nnhg is a singleton and not a blackhole nhg. This was originally\ndone with checking that the nexthop is a NEXTHOP_TYPE_IFINDEX,\nNEXTHOP_TYPE_IPV4_IFINDEX and NEXTHOP_TYPE_IPV6_IFINDEX. This\nwas excluding NEXTHOP_TYPE_IPV4 and NEXTHOP_TYPE_IPV6. These\nwere both possible to be received and maintained from the upper\nlevel protocol for when a route is being recursively resolved.\nIf we have gotten to this point in zebra_interface_nhg_reinstall\nthe nexthop group has already been installed at least once\nand we *know* that it is actually a valid nexthop. What the\ntest is really trying to do is ensure that we are not reinstalling\na blackhole nexthop group( Which is not possible to even be\nhere by the way, but safety first! ). So let's change\nto test for that instead.\n\nSigned-off-by: Donald Sharp ","shortMessageHtmlLink":"lib, zebra: Check for not being a blackhole route"}},{"before":"8ff34022bbc9e48bfe6bc8354f6398e9d4e0a0e8","after":"cfee4e3cf535d8ab6cdca8048a0b0408a2c13eeb","ref":"refs/heads/rpki_as_0","pushedAt":"2024-04-17T15:40:30.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"donaldsharp","name":"Donald Sharp","path":"/donaldsharp","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10601296?s=80&v=4"},"commit":{"message":"bgpd: Allow specification of AS 0 for rpki commands\n\nRFC-7607 specifically calls out the allowed usage\nof AS 0 to signal that the a particular address is\nnot in use and should be guarded against. Add\nthe ability to specify this special AS in the rpki\ncommands.\n\neva# show rpki as-number 0\nRPKI/RTR prefix table\nPrefix Prefix Length Origin-AS\n2.57.180.0 22 - 24 0\n2.58.144.0 22 - 22 0\n2.59.116.0 24 - 24 0\n4.42.228.0 22 - 22 0\n5.57.80.0 22 - 22 0\n\n2a13:df87:b400:: 38 - 38 0\n2a13:df84:: 32 - 32 0\n2630:: 16 - 16 0\nNumber of IPv4 Prefixes: 1166\nNumber of IPv6 Prefixes: 617\n\neva# show rpki prefix 2630::/16 0\nPrefix Prefix Length Origin-AS\n2630:: 16 - 16 0\neva#\n\nFixes: #15778\nSigned-off-by: Donald Sharp ","shortMessageHtmlLink":"bgpd: Allow specification of AS 0 for rpki commands"}},{"before":null,"after":"8ff34022bbc9e48bfe6bc8354f6398e9d4e0a0e8","ref":"refs/heads/rpki_as_0","pushedAt":"2024-04-17T13:42:08.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"donaldsharp","name":"Donald Sharp","path":"/donaldsharp","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10601296?s=80&v=4"},"commit":{"message":"bgpd: Allow specification of AS 0 for rpki commands\n\nRFC-7607 specifically calls out the allowed usage\nof AS 0 to signal that the a particular address is\nnot in use and should be guarded against. Add\nthe ability to specify this special AS in the rpki\ncommands.\n\nFixes: #15778\nSigned-off-by: Donald Sharp ","shortMessageHtmlLink":"bgpd: Allow specification of AS 0 for rpki commands"}},{"before":"cc4d97918a86ebf777541a7961815b8e4bb11df0","after":"bc9885b22e79ac14fd931517582d0d6d80f68c85","ref":"refs/heads/med_value","pushedAt":"2024-04-15T16:34:02.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"donaldsharp","name":"Donald Sharp","path":"/donaldsharp","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10601296?s=80&v=4"},"commit":{"message":"bgpd: Fix display when using `missing-as-worst`\n\nThe usage of the `bgp bestpath med missing-as-worst` command\nwas being accepted and applied during bestpath, but during output\nof the routes affected by this it would not give any indication\nthat this was happening or what med value was being used.\n\nFixes: #15718\nSigned-off-by: Donald Sharp ","shortMessageHtmlLink":"bgpd: Fix display when using missing-as-worst"}},{"before":"ab75b4d3e084ddbbe44e040b739c12eb60f9a8e6","after":"c8e0ece39d046d5cd0aa18ff27bbb99a28f5a9cc","ref":"refs/heads/evpn_zebra_interactions","pushedAt":"2024-04-12T11:35:45.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"donaldsharp","name":"Donald Sharp","path":"/donaldsharp","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10601296?s=80&v=4"},"commit":{"message":"bgpd: Convert int's to bool in a couple of spots\n\nSigned-off-by: Donald Sharp ","shortMessageHtmlLink":"bgpd: Convert int's to bool in a couple of spots"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEWTNEkgA","startCursor":null,"endCursor":null}},"title":"Activity ยท donaldsharp/frr"}