Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New functionality broke the font fallback funtion #3364

Open
robvanderlee opened this issue Jan 4, 2024 · 2 comments
Open

New functionality broke the font fallback funtion #3364

robvanderlee opened this issue Jan 4, 2024 · 2 comments

Comments

@robvanderlee
Copy link

robvanderlee commented Jan 4, 2024

I've tested the font fallback feature for a while and when updating to the 2.0.3 or 2.0.4 release this somehow got broken. I've yet to dive into this with some more concrete pointers.

What I can tell is that when the feature got merged we ran on dev-master#87bea32 which has a working result. The release after this commit (2.0.3) will not work, being the official release for this functionality in the first place :(

@bsweeney
Copy link
Member

bsweeney commented Jan 4, 2024

The font fallback functionality hasn't been officially released yet. 2.0.4 is just 2.0.3 with a minor change to address a recursion vulnerability. The font fallback functionality will be released as part of Dompdf 3.0.0. I'm working through some updates in dependencies (primarily php-font-lib to fix issues with font parsing and subsetting) before I finalize the release.

In the meantime, you can access the fallback functionality by referencing dev-master in your composer configuration.

@8ctopus
Copy link

8ctopus commented Jan 8, 2024

@bsweeney Could you please tag the font fallback?

I'm using this is my package json:

"require": {
    "dompdf/dompdf": "dev-master#05abdb3dbf51cb2263080b500a63ec483d5d4125",
},

however the composer json that requires the package, nevertheless automatically updates to dev-master HEAD on composer update which is dangerous.

$ composer update
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 1 update, 0 removals
  - Upgrading dompdf/dompdf (dev-master 05abdb3 => dev-master c9cf4be)
Writing lock file
Installing dependencies from lock file (including require-dev)
Nothing to install, update or remove
Generating optimized autoload files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants