Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax requirements for test #141

Open
jeroenheijmans opened this issue May 14, 2017 · 1 comment
Open

Relax requirements for test #141

jeroenheijmans opened this issue May 14, 2017 · 1 comment

Comments

@jeroenheijmans
Copy link
Contributor

The test.sh file checks the output of a raffler using:

if [[ "$winner" != *"Reinier Kip"* ]]; then

It would be nice if this was changed to e.g. a "StartsWith("Reinier Kip")" or even a regex of some sort, so that the rafflers can add some details (e.g. an explanation or addendum) to the winner.
@lucasvanlierop
Copy link
Contributor

Didn't get to fixing this, but a PR is welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lucasvanlierop @jeroenheijmans